medplum / medplum / 23208692891

92%

push

github

Improve $find service type matching (#8683)

The initial implementation here worked for exact matching of both
"system" and "code" elements of the search, but we want to support
some more cases. The most common one is coding values with no system
component; for example, in our defining-availability documentation we
use samples like this:
```
  "url": "serviceType",
  "valueCodeableConcept": {
    "coding": [
      { "code": "office-visit" }
    ]
  }
```

We expect that a query like `$find?service-type=office-visit` would
match this, but our earlier attempt wouldn't work for this.

We had been concatenating the system and code components, and so we were
comparing the input string "office-visit" with a computed value from
that coding of "|office-visit" (with the leading delimiter).

I've added utilities that implement the token matching properties
described in the FHIR search documentation (https://build.fhir.org/search.html#token),
and updated $find to use them.

Signed-off-by: Noah Silas <noah@medplum.com>

17896 of 20323 branches covered (88.06%)

Branch coverage included in aggregate %.

10 of 10 new or added lines in 2 files covered. (100.0%)

32514 of 34345 relevant lines covered (94.67%)

14570.14 hits per line