qiniu / kube-ovn / 23175574184
26%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 205
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 23.449% (+0.5%) from 22.981%
23175574184

push

github

web-flow 
fix(controller): backfill nat gateway lan ip safely (#6424)

* fix(controller): backfill nat gateway lan ip and sync status

Backfill spec.lanIp from the running NAT gateway pod using StatefulSet owner references. Also mirror spec.lanIp into status and add tests for both behaviors.

Signed-off-by: jimyag <git@jimyag.com>

* refactor(controller): remove nat gateway status lanIp sync

Keep lanIp as a spec-only field for VpcNatGateway.
Remove redundant status.lanIp updates and related unit test coverage.

Signed-off-by: jimyag <git@jimyag.com>

* fix(controller): guard nat gw lanIp backfill when lister is nil

Fallback to direct API get when vpcNatGatewayLister is not initialized.
This prevents nil pointer panics in lanIp backfill test scenarios.

Signed-off-by: jimyag <git@jimyag.com>

* fix(controller): harden nat gw lanIp backfill checks

Restrict lanIp backfill to controller namespace pods and validate parsed IP values before patching.
Also simplify owner name guard logic and expand unit coverage for namespace and invalid-ip cases.

Signed-off-by: jimyag <git@jimyag.com>

* fix(controller): select nat gw lan ip by subnet protocol

Choose backfilled lanIp using subnet protocol to avoid preferring IPv4 on IPv6 subnets.
Add unit coverage for IPv6 subnet backfill behavior.

Signed-off-by: jimyag <git@jimyag.com>

* style(test): fix gofumpt formatting in pod backfill test

Apply gofumpt formatting to TestBackfillVpcNatGwLanIPFromPod setup block.
This matches CI lint expectations for Build kube-ovn.

Signed-off-by: jimyag <git@jimyag.com>

* fix(controller): trigger nat gateway reconcile from pod updates only

Limit VpcNatGateway reconcile trigger to NAT gateway pod update paths.
Remove parent enqueue logic from EIP/FIP/DNAT/SNAT child resource enqueue handlers.
Keep lanIP backfill in parent reconcile.

Signed-off-by: jimyag <git@jimyag.com>

* chore(controller): revert non-functional nat gw handler refactors

Signed-off-by: jimyag <git@jimyag.com>

------... (continued)

56 of 103 new or added lines in 2 files covered. (54.37%)

3823 existing lines in 37 files now uncovered.

12883 of 54941 relevant lines covered (23.45%)

0.27 hits per line

Uncovered Changes

Lines Coverage ∆ File
35
12.31
 2.39% pkg/controller/pod.go
12
3.41
 -0.04% pkg/controller/vpc_nat_gateway.go

Coverage Regressions

Lines Coverage ∆ File
558
63.74
 -0.15% pkg/apis/kubeovn/v1/zz_generated.deepcopy.go
301
12.31
 2.39% pkg/controller/pod.go
246
77.87
 0.28% pkg/ovs/ovn-nb-acl.go
207
17.58
 1.9% pkg/controller/vpc.go
161
8.5
 -0.05% pkg/controller/admin_network_policy.go
160
0.0
 0.0% pkg/controller/vpc_egress_gateway.go
158
4.3
 -0.16% pkg/controller/network_policy.go
157
27.0
 -0.34% pkg/controller/cluster_network_policy.go
153
1.0
 0.04% pkg/controller/node.go
145
0.72
 0.72% pkg/controller/init.go
144
79.15
 -0.09% pkg/ovs/ovn-nb-logical_switch_port.go
140
0.0
 0.0% pkg/daemon/ovs_linux.go
137
0.0
 0.0% pkg/daemon/controller.go
136
3.41
 -0.04% pkg/controller/vpc_nat_gateway.go
125
1.14
 0.0% pkg/controller/controller.go
115
0.0
 0.0% pkg/daemon/ipsec.go
104
6.21
 -0.68% pkg/controller/switch_lb_rule.go
80
0.0
 0.0% pkg/ovn_leader_checker/ovn.go
78
14.44
 8.59% pkg/controller/security_group.go
65
0.0
 0.0% pkg/controller/vpc_dns.go
59
0.0
 0.0% pkg/controller/vlan.go
55
0.0
 0.0% pkg/daemon/tproxy_linux.go
50
0.0
 0.0% pkg/controller/service_lb.go
41
6.04
 6.04% pkg/controller/ip.go
33
0.0
 0.0% pkg/daemon/init.go
31
0.0
 0.0% pkg/daemon/ovs.go
31
80.61
 0.0% pkg/ovs/ovn-nb-logical_router_policy.go
30
0.0
 0.0% pkg/controller/vip.go
29
4.24
 0.0% pkg/metrics/dynamic_cert_key.go
23
5.65
 5.65% pkg/controller/subnet_status.go
16
0.0
 0.0% pkg/daemon/init_linux.go
14
73.76
 -0.59% pkg/ovs/ovn-nb-load_balancer.go
13
6.06
 0.0% pkg/controller/vpc_lb.go
12
34.44
 34.44% pkg/speaker/subnet.go
8
17.24
 0.14% pkg/controller/endpoint_slice.go
6
0.0
 0.0% pkg/apis/kubeovn/v1/security-group.go
2
74.6
 -0.53% pkg/ovs/ovn-nb-logical_router_route.go
Jobs
ID Job ID Ran Files Coverage
1 23175574184.1 205
23.45
 GitHub Action Run
Source Files on build 23175574184