tarantool / tarantool / 23169970505

88%

Build Type

push

github

Committed by Gerold103

Commit Message

election: drop promotion flag before entering Raft

box_promote() used to keep is_in_box_promote flag while running
box_raft_try_promote(). Sometimes this led to the Raft worker
being too fast, entering box_promote_qsync(), and failing on
is_in_box_promote being set. Even though it is literally a part
of the same promote.

Lets drop the flag right before entering box_raft_try_promote().

Both before and after the behaviour is really the same. Just
previously the Raft worker had to retry the limbo promotion.
The difference is only detectable in the logs. This is why there
is also no special test for this. The existing ones cover the
guards completely fine.

Closes #12333

NO_DOC=bugfix
NO_CHANGELOG=too minor and no behaviour changes

Coverage Stats

70534 of 118687 branches covered (59.43%)

2 of 2 new or added lines in 1 file covered. (100.0%)

305 existing lines in 16 files now uncovered.

106052 of 120959 relevant lines covered (87.68%)

1364693.93 hits per line