• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

bedrock-kv / bedrock / 81ef521344af7f98c7d078312a615eb154064c5e
74%
develop: 66%

Build:
Build:
LAST BUILD BRANCH: main
DEFAULT BRANCH: develop
Ran 16 Mar 2026 05:48PM UTC
Jobs 2
Files 215
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

16 Mar 2026 05:47PM UTC coverage: 66.004% (+0.2%) from 65.794%
81ef521344af7f98c7d078312a615eb154064c5e

push

github

web-flow
fix: expire waitlisted olivine reads (#73)

Closes #70.

## Summary

This PR hardens Olivine waitlisted reads so they expire inside the
materializer instead of hanging until the caller's outer timeout.

Scope is intentionally narrow:
- add read-request-manager helpers to expire waiting fetches and compute
the next waitlist deadline
- schedule those deadlines from the Olivine GenServer so waitlisted
reads are revisited even when no new transactions arrive
- remove the dead `:waitlist_timing` bookkeeping on the server process
- add an integration regression that proves a waitlisted read returns
`{:error, :waiting_timeout}` and drains the waiting list

This PR does **not** include the fresh-cluster routing fix from #68 or
the persisted restart recovery investigation from #71.

## Why

Today, Olivine only revisits waitlisted reads when transactions are
applied. If the requested version never arrives, the waitlist can grow
indefinitely and callers only fail when an outer `GenServer.call`
timeout fires.

That makes broken catch-up look like a hanging read instead of a clear
materializer-level failure.

## Tests

- `mix test
test/bedrock/data_plane/materializer/olivine/genserver_integration_test.exs`
- `mix credo --strict
lib/bedrock/data_plane/materializer/olivine/reading.ex
lib/bedrock/data_plane/materializer/olivine/server.ex
test/bedrock/data_plane/materializer/olivine/genserver_integration_test.exs`

18 of 20 new or added lines in 2 files covered. (90.0%)

4 existing lines in 2 files now uncovered.

5176 of 7842 relevant lines covered (66.0%)

1955.19 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
2
51.01
2.06% lib/bedrock/data_plane/materializer/olivine/server.ex

Uncovered Existing Lines

Lines Coverage ∆ File
1
88.28
0.37% lib/bedrock/data_plane/transaction.ex
3
74.53
-1.86% lib/bedrock/data_plane/materializer/olivine/index_update.ex
Jobs
ID Job ID Ran Files Coverage
1 81ef521344af7f98c7d078312a615eb154064c5e.1 16 Mar 2026 05:48PM UTC 215
66.0
GitHub Action Run
2 81ef521344af7f98c7d078312a615eb154064c5e.2 16 Mar 2026 05:48PM UTC 215
65.97
GitHub Action Run
Source Files on build 81ef521344af7f98c7d078312a615eb154064c5e
  • Tree
  • List 215
  • Changed 6
  • Source Changed 0
  • Coverage Changed 6
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • 81ef5213 on github
  • Prev Build on main (#49FC51FF...)
  • Next Build on main (#61A4DCD8...)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc