bedrock-kv / bedrock / 81ef521344af7f98c7d078312a615eb154064c5e

74%

develop: 66%

Build Type

push

github

Committed by web-flow

Commit Message

fix: expire waitlisted olivine reads (#73)

Closes #70.

## Summary

This PR hardens Olivine waitlisted reads so they expire inside the
materializer instead of hanging until the caller's outer timeout.

Scope is intentionally narrow:
- add read-request-manager helpers to expire waiting fetches and compute
the next waitlist deadline
- schedule those deadlines from the Olivine GenServer so waitlisted
reads are revisited even when no new transactions arrive
- remove the dead `:waitlist_timing` bookkeeping on the server process
- add an integration regression that proves a waitlisted read returns
`{:error, :waiting_timeout}` and drains the waiting list

This PR does **not** include the fresh-cluster routing fix from #68 or
the persisted restart recovery investigation from #71.

## Why

Today, Olivine only revisits waitlisted reads when transactions are
applied. If the requested version never arrives, the waitlist can grow
indefinitely and callers only fail when an outer `GenServer.call`
timeout fires.

That makes broken catch-up look like a hanging read instead of a clear
materializer-level failure.

## Tests

- `mix test
test/bedrock/data_plane/materializer/olivine/genserver_integration_test.exs`
- `mix credo --strict
lib/bedrock/data_plane/materializer/olivine/reading.ex
lib/bedrock/data_plane/materializer/olivine/server.ex
test/bedrock/data_plane/materializer/olivine/genserver_integration_test.exs`

Run Details

18 of 20 new or added lines in 2 files covered. (90.0%)

4 existing lines in 2 files now uncovered.

5176 of 7842 relevant lines covered (66.0%)

1955.19 hits per line