tarantool / tarantool / 23154065131

88%

Build Type

push

github

Committed by locker

Commit Message

box: make tuple format registry thread-local

In order to be able to create tuples in application threads, we need to
make the tuple registry thread-local. To achieve that, we make all
related global variables thread-local and add some debug checks ensuring
that a format is used only from the thread that created that.

There are two subsystems in Tarantool that rely upon the tuple format
registry being the same in all threads. The first one is Vinyl: it
references space formats by pointer in writer threads. To make it
compatible with thread-local formats, we patch Vinyl to create a
thread-local copy of the space format for each dump/compaction task.
Note that we can't just create a simple tuple format from the key
definition because we still have to check tuple fields while applying
updates. So we pass the space definition via the dump/compaction task
object.

The second subsystem that needs to be patched is the memtx tuple sorter
executed at recovery completion to build secondary indexes. We fix it
by inheriting the tuple format table from the main thread in each sorter
thread. A thread inheriting a tuple format table may look up tuple
formats by id but it may not create, destroy, reference, or unreference
tuple formats. In particular, it means that it may not create or destroy
tuples. Basically, it's useful only for tuple comparison.

Closes #12210

NO_DOC=internal
NO_TEST=already covered
NO_CHANGELOG=internal

Coverage Stats

70505 of 118675 branches covered (59.41%)

88 of 95 new or added lines in 10 files covered. (92.63%)

42 existing lines in 17 files now uncovered.

106027 of 120938 relevant lines covered (87.67%)

1352169.47 hits per line