IgniteUI / igniteui-webcomponents / 23137424857

98%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(splitter): Improved ARIA semantics and code organization (#2145)

Replace `[start-collapsed]` / `[end-collapsed]` reflected attributes with
CSS custom states via ElementInternals (`addInternalsController`). Collapsed
panes are now exposed as `:state(start-collapsed)` / `:state(end-collapsed)`,
keeping the public API surface clean.

- Extract internal types (`PanePosition`, `SplitterPaneState`, `PaneResizeSnapshot`,
  `SplitterResizeState`, event maps) into a dedicated `types.ts` module
- Embed `StyleInfo` directly in `SplitterPaneState` to eliminate separate
  `_startPaneInternalStyles` / `_endPaneInternalStyles` / `_barInternalStyles` fields
- Replace mutation-by-spread with direct property assignment on pane state objects
- Rename `_barRef` → `_separatorRef` for semantic clarity; remove `_updateCursor()`
  (cursor now set inline via `styleMap` in `_renderSeparator()`)
- Unify `_handleExpanderStartAction` / `_handleExpanderEndAction` into
  `_handleExpanderAction(pane)` and simplify `_resolvePartNames`
- Add `_isCollapsed(which)`, `_getPaneState(which)`, and `_isHorizontal` helpers
  to reduce repetitive conditionals
- Extract `_renderSeparator()` and `_renderAccessibleLabel()` render helpers;
  add an `igc-visually-hidden` label announcing current collapse state to assistive
  tech; set `aria-labelledby` on the separator element
- Pass pre-computed `totalSize` into `_createPaneState`, `_setMinMaxInPx`,
  `_setPaneMinMaxSizes`, etc. to avoid redundant `getBoundingClientRect` calls
- Register `IgcVisuallyHiddenComponent` as a sub-dependency
- Extract `KEYBOARD_RESIZE_STEP = 10` constant
- Update base SCSS and all spec assertions to use `:state(...)` selectors
- Expand Storybook: add `Vertical`, `WithConstraints`, and `ProgrammaticCollapse`
  stories; improve all control and component descriptions; fix `NestedSplitters`
  to pass inner splitters directly into named slots

Co-authored-by: Bozhidara Pachilova <35433937+ddaribo@users.noreply.github.com>

Run Details

5539 of 5828 branches covered (95.04%)

Branch coverage included in aggregate %.

354 of 356 new or added lines in 1 file covered. (99.44%)

1 existing line in 1 file now uncovered.

38289 of 38753 relevant lines covered (98.8%)

1533.81 hits per line