ben-manes / caffeine / #5332

100%

push

github

Fix int overflow in hill climber sample counter sum

In determineAdjustment(), hitsInSample() + missesInSample() was computed
as int + int, which silently overflows when the true sum exceeds
Integer.MAX_VALUE. This occurs for caches with maximumSize >= ~107M where
sampleSize saturates at Integer.MAX_VALUE. The overflowed (negative) sum
permanently fails the requestCount < sampleSize check, preventing the
hill climber from adjusting the window/main partition and feeding a
negative hit rate into the step size calculation.

3857 of 3870 branches covered (99.66%)

1 of 1 new or added line in 1 file covered. (100.0%)

7894 of 7905 relevant lines covered (99.86%)

1.0 hits per line