open-source-parsers / jsoncpp / 23129570851

90%

push

github

Fix string_view ABI mismatch between library and consumers (#1661)

The library was forced to build with CMAKE_CXX_STANDARD 11, so
JSONCPP_HAS_STRING_VIEW was never defined at compile time. Consumers
building with C++17 would see the string_view APIs in the header but
fail to link them.

Fix:
- Remove the global CMAKE_CXX_STANDARD 11 override; the existing
  target_compile_features(cxx_std_11) already enforces the minimum.
- Detect string_view support at configure time with
  check_cxx_source_compiles and export JSONCPP_HAS_STRING_VIEW as a
  PUBLIC compile definition on all library targets, so consumers
  always see the same value the library was built with.
- Guard the __cplusplus fallback in value.h so it does not override
  the CMake-set define.

Fixes #1595

2183 of 2589 branches covered (84.32%)

Branch coverage included in aggregate %.

2573 of 2690 relevant lines covered (95.65%)

23748.16 hits per line