ehtick / luma.gl / 23123651889
74%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 263
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 76.879% (-0.07%) from 76.951%
23123651889

push

github

web-flow 
fix(engine): Re-enable GPU timing metrics in AnimationLoop (#2505)

* fix(engine): Re-enable GPU timing metrics in AnimationLoop

The GPU timing code in AnimationLoop was commented out during the v9
migration when the old Query class was removed. This commit re-enables
GPU time measurement using the new QuerySet API:

- Initialize GPU time query when 'timer-query-webgl' feature is available
- Use WEBGLQuerySet's beginTimestampQuery/endTimestampQuery methods
- Record GPU time results in _beginFrameTimers() when available
- Gracefully handle unsupported environments (WebGPU, missing extension)
- Clean up query resources in destroy()

This fixes deck.gl's gpuTimePerFrame metric always reporting 0.

Related: https://github.com/visgl/deck.gl/issues/9958

https://claude.ai/code/session_01H614UvusgZQfwVssKtezh9

* test(engine): Add test for GPU timing graceful fallback

Verifies that AnimationLoop:
- Creates gpuTime and cpuTime stats regardless of timer support
- Initializes _gpuTimeQuery only when timer-query-webgl is available
- Cleans up query resources on destroy without errors

https://claude.ai/code/session_01H614UvusgZQfwVssKtezh9

* comments

* wip

* cleanup

* format

* wip

* wip

* fix

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Xiaoji Chen <cxiaoji@gmail.com>
Co-authored-by: Ib Green <ib@unfolded.ai>

2622 of 3380 branches covered (77.57%)

Branch coverage included in aggregate %.

218 of 503 new or added lines in 10 files covered. (43.34%)

169 existing lines in 11 files now uncovered.

30413 of 39590 relevant lines covered (76.82%)

96.08 hits per line

Uncovered Changes

Lines Coverage ∆ File
183
28.75
 -22.89% modules/webgl/src/adapter/resources/webgl-query-set.ts
38
85.42
 -14.58% modules/core/src/adapter/resources/command-encoder.ts
35
76.38
 -3.36% modules/engine/src/animation-loop/animation-loop.ts
17
52.63
 -31.37% modules/engine/src/animation-loop/request-animation-frame.ts
6
75.64
 -2.61% modules/webgl/src/adapter/resources/webgl-render-pass.ts
3
93.51
 -1.28% modules/core/src/adapter/resources/resource.ts
3
84.85
 -2.25% modules/webgl/src/adapter/resources/webgl-command-encoder.ts

Coverage Regressions

Lines Coverage ∆ File
47
84.81
 0.07% modules/webgl/src/adapter/resources/webgl-texture.ts
43
89.37
 -1.7% modules/webgl/src/adapter/converters/webgl-texture-table.ts
31
90.94
 0.27% modules/core/src/adapter/resources/texture.ts
22
88.57
 0.0% modules/core/src/adapter/device.ts
10
28.75
 -22.89% modules/webgl/src/adapter/resources/webgl-query-set.ts
8
93.51
 -1.28% modules/core/src/adapter/resources/resource.ts
2
97.39
 0.43% modules/core/src/shadertypes/textures/texture-format-decoder.ts
2
52.63
 -31.37% modules/engine/src/animation-loop/request-animation-frame.ts
2
95.65
 0.79% modules/webgl/src/adapter/helpers/get-shader-layout-from-glsl.ts
1
0.0
 0.0% modules/core/src/shadertypes/textures/texture-formats.ts
1
98.8
 0.0% modules/core/src/shadertypes/textures/texture-format-table.ts
Jobs
ID Job ID Ran Files Coverage
1 23123651889.1 263
76.88
 GitHub Action Run
Source Files on build 23123651889