visgl / luma.gl / 23123400261

77%

Build Type

push

github

Committed by web-flow

Commit Message

fix(engine): Re-enable GPU timing metrics in AnimationLoop (#2505)

* fix(engine): Re-enable GPU timing metrics in AnimationLoop

The GPU timing code in AnimationLoop was commented out during the v9
migration when the old Query class was removed. This commit re-enables
GPU time measurement using the new QuerySet API:

- Initialize GPU time query when 'timer-query-webgl' feature is available
- Use WEBGLQuerySet's beginTimestampQuery/endTimestampQuery methods
- Record GPU time results in _beginFrameTimers() when available
- Gracefully handle unsupported environments (WebGPU, missing extension)
- Clean up query resources in destroy()

This fixes deck.gl's gpuTimePerFrame metric always reporting 0.

Related: https://github.com/visgl/deck.gl/issues/9958

https://claude.ai/code/session_01H614UvusgZQfwVssKtezh9

* test(engine): Add test for GPU timing graceful fallback

Verifies that AnimationLoop:
- Creates gpuTime and cpuTime stats regardless of timer support
- Initializes _gpuTimeQuery only when timer-query-webgl is available
- Cleans up query resources on destroy without errors

https://claude.ai/code/session_01H614UvusgZQfwVssKtezh9

* comments

* wip

* cleanup

* format

* wip

* wip

* fix

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Xiaoji Chen <cxiaoji@gmail.com>
Co-authored-by: Ib Green <ib@unfolded.ai>

Run Details

2622 of 3380 branches covered (77.57%)

Branch coverage included in aggregate %.

218 of 503 new or added lines in 10 files covered. (43.34%)

12 existing lines in 2 files now uncovered.

30413 of 39590 relevant lines covered (76.82%)

96.09 hits per line