AAEmu / AAEmu / 23110973097

5%

Build Type

push

github

Committed by web-flow

Commit Message

fix(game): ensure NPC custom model parameters are correctly applied (#1392)

- Assign `Unit.ModelParams` from the `Npc` template's `ModelParams` so `SCUnitState` can actually write it to the client.

- Set the underlying type of `UnitCustomModelType` to byte so it can used more easily for compares.

- Refactor `SCUnitStatePacket` to remove redundant unit casting and object allocations in `Inventory_Equip`.

- Clean up packet code by simplifying ternary expressions and fixing comment typos.

- Adjust visibility of several model parameter properties to improve encapsulation.

- Added `ORDER BY id` to `item_body_parts` queries. This ensures consistent row ordering during model parameter loading, preventing potential issues with NPC looks. This is needed because it's possible to the same slot is assigned multiple times in the database.

Run Details

1 of 20 new or added lines in 5 files covered. (5.0%)

5 existing lines in 2 files now uncovered.

3141 of 63262 relevant lines covered (4.97%)

0.05 hits per line