trixi-framework / Trixi.jl / 23108325999

97%

Build Type

push

github

Committed by web-flow

Commit Message

Refactor DGMulti to use a shared array container (#2853)

* Refactor DGMulti `create_cache` to use shared array-allocation helper

Introduce `DGMultiCommonArrays` struct and `allocate_common_dgmulti_arrays`
to eliminate duplicated allocation of `u_values`, `u_face_values`,
`flux_face_values`, and `local_values_threaded` across the `DGMultiWeakForm`
and `DGMultiFluxDiffSBP` `create_cache` methods.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Store DGMultiCommonArrays as named field in cache, unpack where needed

Replace splatting of `DGMultiCommonArrays` fields into the cache named
tuple with storing the struct directly as `cache.common_arrays`. Update
all access sites across `dg.jl`, `flux_differencing.jl`,
`flux_differencing_gauss_sbp.jl`, `sbp.jl`, and
`analysis_dgmulti.jl` to unpack from `cache.common_arrays`.

Also applies `DGMultiCommonArrays` consistently to all four `create_cache`
variants (`DGMultiWeakForm`, `DGMultiFluxDiffSBP`, `DGMultiFluxDiff`,
`DGMultiFluxDiffPeriodicFDSBP`).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Apply suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix DGMultiCommonArrays type parameter for mismatched face array types

`u_face_values` in the `DGMultiFluxDiff` cache is a view into
`entropy_projected_u_values`, while `flux_face_values = similar(...)`
allocates a fresh array — these have different concrete types.
Split the single `fType` parameter into separate `ufType` and `ffType`
to accommodate this.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* renaming

* fix unpack

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

Run Details

46 of 46 new or added lines in 6 files covered. (100.0%)

2288 existing lines in 88 files now uncovered.

41137 of 47316 relevant lines covered (86.94%)

31880870.0 hits per line