canokeys / canokey-core / 23109080943

93%

master: 94%

Build Type

Pull #141

github

Committed by Harry-Chen

Commit Message

fix(ctaphid): send KEEPALIVE_CANCEL response immediately on CANCEL

When a CBOR command (e.g. authenticatorSelection) is waiting for user
presence and the host sends CTAPHID_CANCEL, the error response was
previously only sent after the entire call-chain unwound back to
CTAPHID_Execute_Cbor. On real hardware this delay caused the response
to be missed by the conformance test tool, which reads with a 400ms
timeout per attempt.

Fix: when CANCEL is received during a pending CBOR command, send the
CTAP2_ERR_KEEPALIVE_CANCEL (0x2D) response directly in the CANCEL
handler inside CTAPHID_Loop. A flag prevents CTAPHID_Execute_Cbor
from sending a duplicate response afterwards.

This should fix conformance tests P-10 and P-15 (CTAPHID CANCEL
during MakeCredential and authenticatorSelection).

Pull Request Pull Request #141: Refactor CTAP for optimized CBOR handling and shared logic

Coverage Stats

100 of 100 new or added lines in 1 file covered. (100.0%)

4 existing lines in 1 file now uncovered.

6106 of 6558 relevant lines covered (93.11%)

329739.89 hits per line