23103890449

Committed 15 Mar 2026 05:08AM UTC coverage: 92.908% (-0.02%) from 92.932%

Build # 23103890449

Build Type

Pull #22949

github

Committed by

web-flow

Commit Message

Merge efc7d06cb into f07276df6

Pull Request Pull Request #22949: Add experimental uv resolver for Python lockfiles

Coverage Stats

66 of 96 new or added lines in 5 files covered. (68.75%)

1 existing line in 1 file now uncovered.

91235 of 98199 relevant lines covered (92.91%)

4.05 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

77.49

/src/python/pants/backend/python/goals/lockfile.py

# Copyright 2021 Pants project contributors (see CONTRIBUTORS.md).
# Licensed under the Apache License, Version 2.0 (see LICENSE).

from __future__ import annotations

import itertools
import os.path
from collections import defaultdict
from dataclasses import dataclass
from operator import itemgetter

from pants.backend.python.subsystems.python_tool_base import PythonToolBase
from pants.backend.python.subsystems.setup import LockfileResolver, PythonSetup
from pants.backend.python.subsystems.uv import Uv
from pants.backend.python.target_types import (
    PythonRequirementFindLinksField,
    PythonRequirementResolveField,
    PythonRequirementsField,
)
from pants.backend.python.util_rules.interpreter_constraints import InterpreterConstraints
from pants.backend.python.util_rules.lockfile_diff import _generate_python_lockfile_diff
from pants.backend.python.util_rules.lockfile_metadata import PythonLockfileMetadata
from pants.backend.python.util_rules.pex import (
    CompletePlatforms,
    digest_complete_platform_addresses,
    find_interpreter,
)
from pants.backend.python.util_rules.pex_cli import PexCliProcess, maybe_log_pex_stderr
from pants.backend.python.util_rules.pex_environment import PexSubsystem
from pants.backend.python.util_rules.pex_requirements import (
    PexRequirements,
    ResolvePexConfig,
    ResolvePexConfigRequest,
    determine_resolve_pex_config,
)
from pants.base.glob_match_error_behavior import GlobMatchErrorBehavior
from pants.core.goals.generate_lockfiles import (
    DEFAULT_TOOL_LOCKFILE,
    GenerateLockfile,
    GenerateLockfileResult,
    GenerateLockfilesSubsystem,
    KnownUserResolveNames,
    KnownUserResolveNamesRequest,
    RequestedUserResolveNames,
    UserGenerateLockfiles,
    WrappedGenerateLockfile,
)
from pants.core.goals.resolves import ExportableTool
from pants.core.util_rules.external_tool import download_external_tool
from pants.core.util_rules.lockfile_metadata import calculate_invalidation_digest
from pants.engine.addresses import UnparsedAddressInputs
from pants.engine.fs import (
    CreateDigest,
    Digest,
    FileContent,
    GlobExpansionConjunction,
    MergeDigests,
    PathGlobs,
)
from pants.engine.internals.native_engine import EMPTY_DIGEST
from pants.engine.internals.synthetic_targets import SyntheticAddressMaps, SyntheticTargetsRequest
from pants.engine.internals.target_adaptor import TargetAdaptor
from pants.engine.intrinsics import (
    create_digest,
    get_digest_contents,
    merge_digests,
    path_globs_to_digest,
)
from pants.engine.platform import Platform
from pants.engine.process import Process, ProcessCacheScope, execute_process_or_raise
from pants.engine.rules import collect_rules, implicitly, rule
from pants.engine.target import AllTargets
from pants.engine.unions import UnionMembership, UnionRule
from pants.option.errors import OptionsError
from pants.option.subsystem import _construct_subsystem
from pants.util.docutil import bin_name
from pants.util.logging import LogLevel
from pants.util.ordered_set import FrozenOrderedSet
from pants.util.pip_requirement import PipRequirement
from pants.util.strutil import softwrap


@dataclass(frozen=True)
class GeneratePythonLockfile(GenerateLockfile):
    requirements: FrozenOrderedSet[str]
    find_links: FrozenOrderedSet[str]
    interpreter_constraints: InterpreterConstraints
    lock_style: str
    complete_platforms: tuple[str, ...]

    @property
    def requirements_hex_digest(self) -> str:
        """Produces a hex digest of the requirements input for this lockfile."""
        return calculate_invalidation_digest(self.requirements)


@rule
async def wrap_python_lockfile_request(request: GeneratePythonLockfile) -> WrappedGenerateLockfile:
    return WrappedGenerateLockfile(request)


@dataclass(frozen=True)
class _PipArgsAndConstraintsSetup:
    resolve_config: ResolvePexConfig
    args: tuple[str, ...]
    digest: Digest


def _strip_named_repo(value: str) -> str:
    """Strip Pex-style named repo values like `name=https://...` down to the URL/path.

    Pants allows `[python-repos].indexes` / `[python-repos].find_links` entries to optionally be
    named so they can be referenced by `--source` in Pex. `uv` does not understand this syntax.
    """
    maybe_name, maybe_url = value.split("=", 1) if "=" in value else ("", value)
    if (
        maybe_name
        and "://" not in maybe_name
        and ("://" in maybe_url or maybe_url.startswith("file:"))
    ):
        return maybe_url
    return value


async def _setup_pip_args_and_constraints_file(resolve_name: str) -> _PipArgsAndConstraintsSetup:
    resolve_config = await determine_resolve_pex_config(
        ResolvePexConfigRequest(resolve_name), **implicitly()
    )

    args = list(resolve_config.pex_args())
    digests: list[Digest] = []

    if resolve_config.constraints_file:
        args.append(f"--constraints={resolve_config.constraints_file.path}")
        digests.append(resolve_config.constraints_file.digest)

    input_digest = await merge_digests(MergeDigests(digests))
    return _PipArgsAndConstraintsSetup(resolve_config, tuple(args), input_digest)


@rule(desc="Generate Python lockfile", level=LogLevel.DEBUG)
async def generate_lockfile(
    req: GeneratePythonLockfile,
    generate_lockfiles_subsystem: GenerateLockfilesSubsystem,
    python_setup: PythonSetup,
    pex_subsystem: PexSubsystem,
    uv: Uv,
    platform: Platform,
) -> GenerateLockfileResult:
    if not req.requirements:
        raise ValueError(
            f"Cannot generate lockfile with no requirements. Please add some requirements to {req.resolve_name}."
        )

    pip_args_setup = await _setup_pip_args_and_constraints_file(req.resolve_name)
    header_delimiter = "//"

    use_uv = python_setup.lockfile_resolver == LockfileResolver.uv
    uv_compile_output_digest: Digest | None = None
    uv_compiled_requirements_path = "__uv_compiled_requirements.txt"
    resolve_config = pip_args_setup.resolve_config

    if use_uv:
        if req.lock_style == "universal":
            raise OptionsError(
                softwrap(
                    f"""
                    `[python].lockfile_resolver = "uv"` does not yet support `lock_style="universal"`.

                    To use uv today, set `[python].resolves_to_lock_style` for `{req.resolve_name}` to
                    `"strict"` or `"sources"`, or set `[python].lockfile_resolver = "pip"`.
                    """
                )
            )
        if req.complete_platforms:
            raise OptionsError(
                softwrap(
                    f"""
                    `[python].lockfile_resolver = "uv"` does not yet support `complete_platforms`.

                    Either remove `[python].resolves_to_complete_platforms` for `{req.resolve_name}`,
                    or set `[python].lockfile_resolver = "pip"`.
                    """
                )
            )

        if resolve_config.overrides or resolve_config.sources or resolve_config.excludes:
            raise OptionsError(
                softwrap(
                    f"""
                    `[python].lockfile_resolver = "uv"` is not yet compatible with per-resolve
                    `overrides`, `sources`, or `excludes` for `{req.resolve_name}`.

                    Either remove these settings for the resolve, or set `[python].lockfile_resolver = "pip"`.
                    """
                )
            )

        # `uv pip compile` resolves for a single interpreter, so only enable it when
        # interpreter constraints narrow to a single major/minor version.
        if not req.interpreter_constraints:
            raise OptionsError(
                softwrap(
                    f"""
                    `[python].lockfile_resolver = "uv"` requires interpreter constraints to be set
                    (and to select a single Python major/minor version) for `{req.resolve_name}`.

                    For example:
                      [python]
                      interpreter_constraints = [\"CPython==3.11.*\"]
                    """
                )
            )
        majors_minors = {
            (maj, minor)
            for maj, minor, _ in req.interpreter_constraints.enumerate_python_versions(
                python_setup.interpreter_versions_universe
            )
        }
        if len(majors_minors) != 1:
            raise OptionsError(
                softwrap(
                    f"""
                    `[python].lockfile_resolver = "uv"` currently requires interpreter constraints
                    to select exactly one Python major/minor version for `{req.resolve_name}`, but
                    the constraints `{req.interpreter_constraints}` select: {sorted(majors_minors)}.

                    Either narrow your constraints (e.g. `CPython==3.11.*`) or set
                    `[python].lockfile_resolver = "pip"`.
                    """
                )
            )

    python = await find_interpreter(req.interpreter_constraints, **implicitly())

    # Resolve complete platform targets if specified
    complete_platforms: CompletePlatforms | None = None
    if req.complete_platforms:
        # Resolve target addresses to get platform JSON files
        complete_platforms = await digest_complete_platform_addresses(
            UnparsedAddressInputs(
                req.complete_platforms,
                owning_address=None,
                description_of_origin=f"the `[python].resolves_to_complete_platforms` for resolve `{req.resolve_name}`",
            )
        )

    # Add complete platforms if specified, otherwise use default target systems for universal locks
    if complete_platforms:
        target_system_args = tuple(
            f"--complete-platform={platform}" for platform in complete_platforms
        )
    elif req.lock_style == "universal":
        # PEX files currently only run on Linux and Mac machines; so we hard code this
        # limit on lock universality to avoid issues locking due to irrelevant
        # Windows-only dependency issues. See this Pex issue that originated from a
        # Pants user issue presented in Slack:
        #   https://github.com/pex-tool/pex/issues/1821
        #
        # Note: --target-system only applies to universal locks. For other lock styles
        # (strict, sources) without complete platforms, we don't specify platform args
        # and PEX will lock for the current platform only.
        target_system_args = (
            "--target-system",
            "linux",
            "--target-system",
            "mac",
        )
    else:
        # For non-universal lock styles without complete platforms, don't specify
        # platform arguments - PEX will lock for the current platform only
        target_system_args = ()

    if generate_lockfiles_subsystem.sync:
        existing_lockfile_digest = await path_globs_to_digest(
            PathGlobs(
                globs=(req.lockfile_dest,),
                # We ignore errors, since the lockfile may not exist.
                glob_match_error_behavior=GlobMatchErrorBehavior.ignore,
                conjunction=GlobExpansionConjunction.any_match,
            )
        )
    else:
        existing_lockfile_digest = EMPTY_DIGEST

    output_flag = "--lock" if generate_lockfiles_subsystem.sync else "--output"

    if use_uv:
        downloaded_uv = await download_external_tool(uv.get_request(platform))

        requirements_in = "__uv_requirements.in"
        uv_input_digest = await create_digest(
            CreateDigest(
                [
                    FileContent(
                        requirements_in,
                        ("\n".join(req.requirements) + "\n").encode("utf-8"),
                    )
                ]
            )
        )

        uv_index_args: list[str] = []
        index_urls = [_strip_named_repo(i) for i in resolve_config.indexes]
        if index_urls:
            uv_index_args.extend(["--default-index", index_urls[0]])
            for extra_index in index_urls[1:]:
                uv_index_args.extend(["--index", extra_index])
        else:
            uv_index_args.append("--no-index")

        uv_find_links_args = list(
            itertools.chain.from_iterable(
                ["--find-links", _strip_named_repo(link)]
                for link in (*resolve_config.find_links, *req.find_links)
            )
        )

        uv_constraints_args: list[str] = []
        if resolve_config.constraints_file:
            uv_constraints_args.extend(["--constraints", resolve_config.constraints_file.path])

        uv_build_args: list[str] = []
        if resolve_config.no_binary:
            uv_build_args.extend(["--no-binary", ",".join(resolve_config.no_binary)])
        if resolve_config.only_binary:
            uv_build_args.extend(["--only-binary", ",".join(resolve_config.only_binary)])

        uv_process_input_digest = await merge_digests(
            MergeDigests([downloaded_uv.digest, uv_input_digest, pip_args_setup.digest])
        )
        uv_result = await execute_process_or_raise(
            **implicitly(
                Process(
                    argv=(
                        downloaded_uv.exe,
                        "pip",
                        "compile",
                        requirements_in,
                        "--output-file",
                        uv_compiled_requirements_path,
                        "--format",
                        "requirements.txt",
                        "--no-header",
                        "--no-annotate",
                        "--python",
                        python.path,
                        *uv_index_args,
                        *uv_find_links_args,
                        *uv_constraints_args,
                        *uv_build_args,
                        *uv.args,
                    ),
                    input_digest=uv_process_input_digest,
                    output_files=(uv_compiled_requirements_path,),
                    description=f"Resolve requirements for {req.resolve_name} with uv",
                    cache_scope=ProcessCacheScope.PER_SESSION,
                )
            )
        )
        uv_compile_output_digest = uv_result.output_digest

    result = await execute_process_or_raise(
        **implicitly(
            PexCliProcess(
                subcommand=("lock", "sync" if generate_lockfiles_subsystem.sync else "create"),
                extra_args=(
                    f"{output_flag}={req.lockfile_dest}",
                    f"--style={req.lock_style}",
                    "--pip-version",
                    python_setup.pip_version,
                    "--resolver-version",
                    "pip-2020-resolver",
                    "--preserve-pip-download-log",
                    "pex-pip-download.log",
                    *target_system_args,
                    # This makes diffs more readable when lockfiles change.
                    "--indent=2",
                    f"--python-path={python.path}",
                    *(f"--find-links={link}" for link in req.find_links),
                    *pip_args_setup.args,
                    # When complete platforms are specified, don't pass interpreter constraints.
                    # The complete platforms already define Python versions and platforms.
                    # Passing both causes PEX to generate duplicate locked_requirements entries
                    # when the local platform matches a complete platform.
                    # TODO(#9560): Consider validating that these platforms are valid with the
                    #  interpreter constraints.
                    *(
                        req.interpreter_constraints.generate_pex_arg_list()
                        if not complete_platforms
                        else ()
                    ),
                    *(
                        f"--override={override}"
                        for override in pip_args_setup.resolve_config.overrides
                    ),
                    *(
                        (
                            "--no-transitive",
                            "--requirement",
                            uv_compiled_requirements_path,
                        )
                        if use_uv
                        else tuple(req.requirements)
                    ),
                ),
                additional_input_digest=await merge_digests(
                    MergeDigests(
                        [existing_lockfile_digest, pip_args_setup.digest]
                        + ([uv_compile_output_digest] if uv_compile_output_digest else [])
                        + ([complete_platforms.digest] if complete_platforms else [])
                    )
                ),
                output_files=(req.lockfile_dest,),
                description=f"Generate lockfile for {req.resolve_name}",
                # Instead of caching lockfile generation with LMDB, we instead use the invalidation
                # scheme from `lockfile_metadata.py` to check for stale/invalid lockfiles. This is
                # necessary so that our invalidation is resilient to deleting LMDB or running on a
                # new machine.
                #
                # We disable caching with LMDB so that when you generate a lockfile, you always get
                # the most up-to-date snapshot of the world. This is generally desirable and also
                # necessary to avoid an awkward edge case where different developers generate
                # different lockfiles even when generating at the same time. See
                # https://github.com/pantsbuild/pants/issues/12591.
                cache_scope=ProcessCacheScope.PER_SESSION,
            )
        )
    )
    maybe_log_pex_stderr(result.stderr, pex_subsystem.verbosity)

    metadata = PythonLockfileMetadata.new(
        valid_for_interpreter_constraints=req.interpreter_constraints,
        requirements={
            PipRequirement.parse(
                i,
                description_of_origin=f"the lockfile {req.lockfile_dest} for the resolve {req.resolve_name}",
            )
            for i in req.requirements
        },
        manylinux=pip_args_setup.resolve_config.manylinux,
        requirement_constraints=(
            set(pip_args_setup.resolve_config.constraints_file.constraints)
            if pip_args_setup.resolve_config.constraints_file
            else set()
        ),
        only_binary=set(pip_args_setup.resolve_config.only_binary),
        no_binary=set(pip_args_setup.resolve_config.no_binary),
        excludes=set(pip_args_setup.resolve_config.excludes),
        overrides=set(pip_args_setup.resolve_config.overrides),
        sources=set(pip_args_setup.resolve_config.sources),
        lock_style=req.lock_style,
        complete_platforms=req.complete_platforms,
    )
    regenerate_command = (
        generate_lockfiles_subsystem.custom_command
        or f"{bin_name()} generate-lockfiles --resolve={req.resolve_name}"
    )
    if python_setup.separate_lockfile_metadata_file:
        descr = f"This lockfile was generated by Pants. To regenerate, run: {regenerate_command}"
        metadata_digest = await create_digest(
            CreateDigest(
                [
                    FileContent(
                        PythonLockfileMetadata.metadata_location_for_lockfile(req.lockfile_dest),
                        metadata.to_json(with_description=descr).encode(),
                    ),
                ]
            )
        )
        final_lockfile_digest = await merge_digests(
            MergeDigests([metadata_digest, result.output_digest])
        )
    else:
        initial_lockfile_digest_contents = await get_digest_contents(result.output_digest)
        lockfile_with_header = metadata.add_header_to_lockfile(
            initial_lockfile_digest_contents[0].content,
            regenerate_command=regenerate_command,
            delimeter=header_delimiter,
        )
        final_lockfile_digest = await create_digest(
            CreateDigest(
                [
                    FileContent(req.lockfile_dest, lockfile_with_header),
                ]
            )
        )

    if req.diff:
        diff = await _generate_python_lockfile_diff(
            final_lockfile_digest, req.resolve_name, req.lockfile_dest
        )
    else:
        diff = None

    return GenerateLockfileResult(final_lockfile_digest, req.resolve_name, req.lockfile_dest, diff)


class RequestedPythonUserResolveNames(RequestedUserResolveNames):
    pass


class KnownPythonUserResolveNamesRequest(KnownUserResolveNamesRequest):
    pass


@rule
async def determine_python_user_resolves(
    _: KnownPythonUserResolveNamesRequest,
    python_setup: PythonSetup,
    union_membership: UnionMembership,
) -> KnownUserResolveNames:
    """Find all know Python resolves, from both user-created resolves and internal tools."""
    python_tool_resolves = ExportableTool.filter_for_subclasses(union_membership, PythonToolBase)

    tools_using_default_resolve = [
        resolve_name
        for resolve_name, subsystem_cls in python_tool_resolves.items()
        if (await _construct_subsystem(subsystem_cls)).install_from_resolve is None
    ]

    return KnownUserResolveNames(
        names=(
            *python_setup.resolves.keys(),
            *tools_using_default_resolve,
        ),  # the order of the keys doesn't matter since shadowing is done in `setup_user_lockfile_requests`
        option_name="[python].resolves",
        requested_resolve_names_cls=RequestedPythonUserResolveNames,
    )


@rule
async def setup_user_lockfile_requests(
    requested: RequestedPythonUserResolveNames,
    all_targets: AllTargets,
    python_setup: PythonSetup,
    union_membership: UnionMembership,
) -> UserGenerateLockfiles:
    """Transform the names of resolves requested into the `GeneratePythonLockfile` request object.

    Shadowing is done here by only checking internal resolves if the resolve is not a user-created
    resolve.
    """
    if not (python_setup.enable_resolves and python_setup.resolves_generate_lockfiles):
        return UserGenerateLockfiles()

    resolve_to_requirements_fields = defaultdict(set)
    find_links: set[str] = set()
    for tgt in all_targets:
        if not tgt.has_fields((PythonRequirementResolveField, PythonRequirementsField)):
            continue
        resolve = tgt[PythonRequirementResolveField].normalized_value(python_setup)
        resolve_to_requirements_fields[resolve].add(tgt[PythonRequirementsField])
        find_links.update(tgt[PythonRequirementFindLinksField].value or ())

    tools = ExportableTool.filter_for_subclasses(union_membership, PythonToolBase)

    out = set()
    for resolve in requested:
        if resolve in python_setup.resolves:
            out.add(
                GeneratePythonLockfile(
                    requirements=PexRequirements.req_strings_from_requirement_fields(
                        resolve_to_requirements_fields[resolve]
                    ),
                    find_links=FrozenOrderedSet(find_links),
                    interpreter_constraints=InterpreterConstraints(
                        python_setup.resolves_to_interpreter_constraints.get(
                            resolve, python_setup.interpreter_constraints
                        )
                    ),
                    resolve_name=resolve,
                    lockfile_dest=python_setup.resolves[resolve],
                    diff=False,
                    lock_style=python_setup.resolves_to_lock_style().get(resolve, "universal"),
                    complete_platforms=tuple(
                        python_setup.resolves_to_complete_platforms().get(resolve, [])
                    ),
                )
            )
        else:
            tool_cls: type[PythonToolBase] = tools[resolve]
            tool = await _construct_subsystem(tool_cls)

            # TODO: we shouldn't be managing default ICs in lockfile identification.
            #   We should find a better place to do this or a better way to default
            if tool.register_interpreter_constraints:
                ic = tool.interpreter_constraints
            else:
                ic = InterpreterConstraints(tool.default_interpreter_constraints)

            out.add(
                GeneratePythonLockfile(
                    requirements=FrozenOrderedSet(sorted(tool.requirements)),
                    find_links=FrozenOrderedSet(find_links),
                    interpreter_constraints=ic,
                    resolve_name=resolve,
                    lockfile_dest=DEFAULT_TOOL_LOCKFILE,
                    diff=False,
                    lock_style="universal",  # Tools always use universal style
                    complete_platforms=(),  # Tools don't use complete platforms
                )
            )

    return UserGenerateLockfiles(out)


@dataclass(frozen=True)
class PythonSyntheticLockfileTargetsRequest(SyntheticTargetsRequest):
    """Register the type used to create synthetic targets for Python lockfiles.

    As the paths for all lockfiles are known up-front, we set the `path` field to
    `SyntheticTargetsRequest.SINGLE_REQUEST_FOR_ALL_TARGETS` so that we get a single request for all
    our synthetic targets rather than one request per directory.
    """

    path: str = SyntheticTargetsRequest.SINGLE_REQUEST_FOR_ALL_TARGETS


def synthetic_lockfile_target_name(resolve: str) -> str:
    return f"_{resolve}_lockfile"


@rule
async def python_lockfile_synthetic_targets(
    request: PythonSyntheticLockfileTargetsRequest,
    python_setup: PythonSetup,
) -> SyntheticAddressMaps:
    if not python_setup.enable_synthetic_lockfiles:
        return SyntheticAddressMaps()

    resolves = [
        (os.path.dirname(lockfile), os.path.basename(lockfile), name)
        for name, lockfile in python_setup.resolves.items()
    ]

    return SyntheticAddressMaps.for_targets_request(
        request,
        [
            (
                os.path.join(spec_path, "BUILD.python-lockfiles"),
                tuple(
                    TargetAdaptor(
                        "_lockfiles",
                        name=synthetic_lockfile_target_name(name),
                        sources=(lockfile,),
                        __description_of_origin__=f"the [python].resolves option {name!r}",
                    )
                    for _, lockfile, name in lockfiles
                ),
            )
            for spec_path, lockfiles in itertools.groupby(sorted(resolves), key=itemgetter(0))
        ],
    )


def rules():
    return (
        *collect_rules(),
        UnionRule(GenerateLockfile, GeneratePythonLockfile),
        UnionRule(KnownUserResolveNamesRequest, KnownPythonUserResolveNamesRequest),
        UnionRule(RequestedUserResolveNames, RequestedPythonUserResolveNames),
        UnionRule(SyntheticTargetsRequest, PythonSyntheticLockfileTargetsRequest),
    )

pantsbuild / pants / 23103890449

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous