chideat / valkey-operator / 23090196489

22%

push

github

fix: prevent data loss during cross-version rolling upgrade (#66)

* fix: use SHUTDOWN NOSAVE when dbsize is 0 to prevent data loss during cross-version rolling upgrade

During a rolling upgrade (e.g. 7.2 → 9.0), a node demoted to replica may attempt
a fullsync from the new-version master. If the RDB format is incompatible, the load
fails after memory has already been cleared, leaving an empty in-memory state.
A subsequent SHUTDOWN (with save) would then overwrite the valid dump.rdb with empty data.

Fix: re-check Dbsize right before SHUTDOWN. If 0, use SHUTDOWN NOSAVE to preserve the
existing dump.rdb (which holds valid pre-upgrade data). If >0, use normal SHUTDOWN.

Applies to both failover/sentinel and cluster shutdown paths.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: improve test coverage for shutdown dbsize check to fix Coveralls failure

Extract shutdownNode helper in cluster and failover packages, switch
from Info().Dbsize to DBSIZE command for testability with miniredis,
and replace no-op tests with real tests that exercise both branches.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

23 of 32 new or added lines in 2 files covered. (71.88%)

4615 of 20612 relevant lines covered (22.39%)

0.26 hits per line