pulibrary / bibdata / 997b7869-c4ec-41b8-bb7d-b41102d6f999

90%

main: 90%

Build Type

Pull #3115

circleci

Committed by sandbergja

Commit Message

Re-implement publication_citation_display in Rust

My first attempt was slower than the ruby version,
due to the overhead of re-parsing the MARC record
for every call to Rust.

However, by grouping all the publication data
together as a hash, we only need to experience that
overhead once per record, and we get a nice speedup:

```
require 'benchmark/ips'
record = MARC::XMLReader.new('spec/fixtures/marc_to_solr/9939238033506421.mrx').first
marc_breaker = MarcBreaker.break(record)
Benchmark.ips do |x|
  x.report("before") { set_pub_citation(record) && BibdataRs::Marc.publication_statements(marc_breaker) }
  x.report("after") { BibdataRs::Marc.publication_data(marc_breaker) }
end
```

```
ruby 3.4.4 (2025-05-14 revision a38531fd3f) +YJIT +PRISM [arm64-darwin24]
Warming up --------------------------------------
              before     2.837k i/100ms
Calculating -------------------------------------
              before     27.827k (± 2.0%) i/s   (35.94 μs/i) -    141.850k in   5.099585s
```

```
ruby 3.4.4 (2025-05-14 revision a38531fd3f) +YJIT +PRISM [arm64-darwin24]
Warming up --------------------------------------
               after     4.137k i/100ms
Calculating -------------------------------------
               after     41.399k (± 1.6%) i/s   (24.16 μs/i) -    210.987k in   5.097755s
```

Pull Request Pull Request #3115: Re-implement publication_citation_display in Rust

Run Details

87 of 97 new or added lines in 3 files covered. (89.69%)

11 existing lines in 1 file now uncovered.

9758 of 10855 relevant lines covered (89.89%)

269.34 hits per line