mostafa / xk6-kafka / 23087537966

71%

Build Type

push

github

Committed by web-flow

Commit Message

Fix: Support wrapped primitive types in Avro union fields (#379)

* Fix: Support wrapped primitive types in Avro union fields

Fixes #376

The convertUnionField function was unable to handle wrapped primitive
types in union fields (e.g., {"int": 20474} or {"int.date": 20474}).
This caused serialization errors when users attempted to send data
in this format for union types containing primitives with logical types.

Changes:
- Add getPrimitiveTypeName helper to map Avro schema types to primitive names
- Update convertUnionField to recognize and unwrap wrapped primitive types
- Handle logical type suffixes (e.g., "int.date" -> "int") by stripping suffix
- Return unwrapped primitive values directly (hamba/avro expects unwrapped primitives)

The fix ensures that both wrapped formats work:
- {"int": 20474} -> unwraps to int32(20474)
- {"int.date": 20474} -> strips suffix and unwraps to int32(20474)

Added comprehensive tests to verify the fix works for various primitive types
and union combinations.

* Add test script

* Fix linter issues

* Fix Avro logical union date handling for issue #376

Normalize logical primitive union values to the discriminator format expected by hamba/avro, preventing float64/unknown union errors in nested schemas. Document supported input shapes for logical union fields and add regression coverage for serialize and conversion paths.

* Refine logical union roundtrip regression test

Replace the skipped logical union test with a focused roundtrip assertion that validates deserialize output type/value for date unions, avoiding overlap with serialize-path coverage.

* Address golangci-lint findings in Avro conversion paths

Fix unsafe byte narrowing in bytes conversion with explicit range checks and reduce duplicated logical date schema literals in tests by reusing a shared constant.

* Update CI Go patch version for xk6 build compatibility

Pin GitHub Actions setup-go to 1.25.8 and enable check-latest so go install xk6@latest mee... (continued)

Run Details

86 of 162 new or added lines in 1 file covered. (53.09%)

2 existing lines in 1 file now uncovered.

2005 of 2827 relevant lines covered (70.92%)

14.52 hits per line