NVIDIA / holodeck / 23084724262

56%

main: 48%

Build Type

push

github

Committed by ArangoGutierrez

Commit Message

fix: address Copilot review — remove duplicate route table, use hostForNode, add real tests

1. Remove orphaned createRouteTable() call in cluster mode — private subnet
   gets NAT-routed table from createPrivateRouteTable(), public subnet gets
   IGW-routed table from createPublicRouteTable(). The old call created an
   unused IGW table for the private subnet.

2. Complete hostForNode migration in GetClusterHealth — match nodes by both
   PublicIP and PrivateIP so SSM transport nodes (no public IP) are found.
   GetClusterHealthFromEnv falls back to PrivateIP when PublicIP is empty.

3. Replace trivial compile-time checks with 6 behavioral mock tests:
   - TestCreateInstancesSetsNoPublicIP (captures RunInstancesInput)
   - TestCreateInstancesUsesRoleSecurityGroup (CP/Worker SG selection)
   - TestPrivateRouteTableRoutesToNATGW (NAT GW, not IGW)
   - TestPublicRouteTableRoutesToIGW (IGW + public subnet association)
   - TestPublicSubnetCreatedInCorrectCIDR (10.0.1.0/24)
   - TestNATGatewayCreatedInPublicSubnet (placed in public subnet)

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

Run Details

0 of 28 new or added lines in 2 files covered. (0.0%)

1 existing line in 1 file now uncovered.

3637 of 6511 relevant lines covered (55.86%)

0.62 hits per line