zhmcclient / python-zhmcclient / test-4436

78%

push

github

Improved logging for end2end testcases (#2121)

Details:

* Used the existing pytest fixture 'zhmc_logger' in all end2end test functions
  in order to get automatic entry and exit log records.

* Improved the zhmc_logger fixture to show the pytest test ID/name in the
  entry and exit log records.

* Fixed that the zhmc_logger fixture added the file handler with every
  invocation, which lead to duplicated log records in the log file.

* Added a new utils function skip_log() that skips the testcase but logs the
  skip message. That allows to see in the log why the function left again
  shortly after entering. It also allows to see which HMC interactions or
  zhmcclient API calls were made before and after the skip.

* Changed any use of skip_warn() to use the new skip_log(). That moves the
  skip information into the log file which is now always created, and allows
  to much better relate the skip messages to the test functions.

* As part of that, all skipif_*() functions got an additional argument for
  the logger.

Signed-off-by: Andreas Maier <maiera@de.ibm.com>

1851 of 2830 branches covered (65.41%)

Branch coverage included in aggregate %.

9509 of 11822 relevant lines covered (80.43%)

9.65 hits per line