kubeflow / trainer / 23068303598
73%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 40
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 56.897% (-1.5%) from 58.356%
23068303598

push

github

web-flow 
feat: add support for tracking TrainJob progress and training metrics (#3227)

* feat(api): add progress types to api

Signed-off-by: Rob Bell <robell@redhat.com>

* feat: progress server stub

Signed-off-by: Rob Bell <robell@redhat.com>

* feat: setup tls for server

Signed-off-by: Rob Bell <robell@redhat.com>

* refactor: pull out middleware

Signed-off-by: Rob Bell <robell@redhat.com>

* refactor: remove logger message noise from tests

Signed-off-by: Rob Bell <robell@redhat.com>

* fix: send server error logs to main logger

Signed-off-by: Rob Bell <robell@redhat.com>

* feat: update the trainer status

Signed-off-by: Rob Bell <robell@redhat.com>

* feat: use separate client to avoid impacting main reconciler client-side rate limits

Signed-off-by: Rob Bell <robell@redhat.com>

* feat: configure progress server in helm chart and configmap

Signed-off-by: Rob Bell <robell@redhat.com>

* fix: prevent race condition

Signed-off-by: Rob Bell <robell@redhat.com>

* feat: inject progress runtime config

Signed-off-by: Rob Bell <robell@redhat.com>

* fix: progress client config

Signed-off-by: Rob Bell <robell@redhat.com>

* fix: update generated config

Signed-off-by: Rob Bell <robell@redhat.com>

* feat: validate auth tokens in endpoint

Signed-off-by: Rob Bell <robell@redhat.com>

* test: validate auth tokens in endpoint

Signed-off-by: Rob Bell <robell@redhat.com>

* refactor: tidy tests to use same format as other tests

Signed-off-by: Rob Bell <robell@redhat.com>

* fix: look up the cluster issuer from the service account token

Different clusters can use different issuers so look up the issuer from the trusted in-cluster service account token.

Signed-off-by: Rob Bell <robell@redhat.com>

* refactor: rename authn middleware

Signed-off-by: Rob Bell <robell@redhat.com>

* feat: add authn to status update endpoint

Signed-off-by: Rob Bell <robell@redhat.com>

* refactor: tidy up reading in-cluster service account token

Signed-off-by: Rob Bell <robe... (continued)

233 of 483 new or added lines in 23 files covered. (48.24%)

160 existing lines in 18 files now uncovered.

1951 of 3429 relevant lines covered (56.9%)

0.65 hits per line

Uncovered Changes

Lines Coverage ∆ File
93
41.14
pkg/statusserver/server.go
77
0.0
pkg/statusserver/auth.go
33
0.0
pkg/statusserver/setup.go
19
0.0
0.0% pkg/util/cert/cert.go
9
92.68
pkg/runtime/framework/plugins/trainjobstatus/trainjobstatus.go
6
80.0
-20.0% pkg/config/validation.go
6
0.0
0.0% pkg/runtime/framework/plugins/registry.go
3
0.0
0.0% pkg/runtime/core/core.go
3
50.0
pkg/statusserver/utils.go
1
0.0
0.0% pkg/controller/trainjob_controller.go

Coverage Regressions

Lines Coverage ∆ File
21
0.0
0.0% pkg/util/cert/cert.go
19
67.48
0.0% pkg/runtime/core/trainingruntime.go
18
47.71
0.0% pkg/runtime/framework/plugins/volcano/volcano.go
17
33.33
0.0% pkg/runtime/framework/plugins/coscheduling/coscheduling.go
16
77.46
0.0% pkg/runtime/framework/plugins/flux/flux.go
15
47.28
0.0% pkg/runtime/framework/plugins/jobset/jobset.go
9
85.0
0.0% pkg/runtime/framework/plugins/mpi/mpi.go
8
0.0
0.0% pkg/features/features.go
8
84.69
0.0% pkg/runtime/framework/core/framework.go
7
0.0
0.0% pkg/runtime/framework/plugins/registry.go
6
80.0
-20.0% pkg/config/validation.go
4
33.33
0.0% pkg/runtime/core/clustertrainingruntime.go
3
0.0
0.0% pkg/runtime/core/core.go
3
94.92
0.0% pkg/runtime/framework/plugins/torch/torch.go
2
88.68
0.0% pkg/runtime/framework/plugins/jax/jax.go
2
94.32
0.0% pkg/runtime/framework/plugins/xgboost/xgboost.go
1
0.0
0.0% pkg/runtime/core/registry.go
1
87.5
0.0% pkg/runtime/framework/plugins/plainml/plainml.go
Jobs
ID Job ID Ran Files Coverage
1 23068303598.1 40
56.9
GitHub Action Run
Source Files on build 23068303598