supabase / supavisor / 23062692966

82%

Build Type

push

github

Committed by web-flow

Commit Message

refactor: improve authentication (#872)

- Implement dedicated modules for ClientHandler authentication through
SCRAM, Password or JIT (consequently, removes most of the
`ClientHandler.Auth` module and a good chunk of code from the
`ClientHandler` module)
- Determines whether to use JIT based on a `jit` connection option
- Uses the plain structs for secrets, instead of wrapping them in
anonymous functions
- Adds support for using JIT in the dev env with a make target and
script
- Moves auth query functionality from ad-hoc modules to a dedicated
module, reducing duplication
- Adds a new `upstream_tls` key in the id indicating whether the pool
uses upstream tls or not. We can virtually have 1 pool with TLS enabled
and one without. This is used to ensure that we don't use upstream TLS
when `tenant.use_jit + client is connecting through cleartext`, which
allows us to use SCRAM-SHA-256 upstream instead of `password`.
- Merged #867 due to the need of adding an extra field in the id

Run Details

378 of 421 new or added lines in 31 files covered. (89.79%)

9 existing lines in 5 files now uncovered.

2360 of 2881 relevant lines covered (81.92%)

59896.52 hits per line