accordproject / concerto / 23061611547

98%

push

github

fix(concerto-core): fix logic error in skipValidationAndResolution guard (#1158)

* Initial plan

* fix(concerto-core): fix logic error in skipValidationAndResolution guard

The condition `!options?.disableMetamodelValidation === false` was
incorrectly evaluating to `true` when `disableMetamodelValidation` is
`true`, causing an error to be thrown in a configuration that should
be allowed. Fixed to `options?.disableMetamodelValidation === false`
to correctly mirror the `disableMetamodelResolution` check.

Signed-off-by: Copilot <copilot@github.com>

Co-authored-by: jamieshorten <842103+jamieshorten@users.noreply.github.com>

* fix(concerto-core): revert unrelated type and package-lock changes

Remove inadvertently staged changes to types/ files and package-lock.json
that were unrelated to the skipValidationAndResolution logic fix.

Signed-off-by: Copilot <copilot@github.com>

Co-authored-by: jamieshorten <842103+jamieshorten@users.noreply.github.com>

* test(concerto-core): add targeted throw tests for skipValidationAndResolution

Add two additional tests covering the case where skipValidationAndResolution
is true and either disableMetamodelResolution or disableMetamodelValidation
is individually set to false (each should throw).

Signed-off-by: Copilot <copilot@github.com>

Co-authored-by: jamieshorten <842103+jamieshorten@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jamieshorten <842103+jamieshorten@users.noreply.github.com>

2209 of 2291 branches covered (96.42%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

4049 of 4080 relevant lines covered (99.24%)

155265.71 hits per line