Azure / ARO-RP / 23055849588

37%

push

github

ARO-24545: Add pre-flight SKU and quota validation for control plane VM resize (#4662)

* WIP SKU checks

* Add pre-flight SKU and quota validation for control plane VM resize

Implement the preresizevalidation admin API endpoint that the Geneva
Action's ResizeControlPlaneVMs orchestration calls before cordoning
any master node.  Validating before the first destructive action
prevents leaving clusters in a degraded etcd quorum state.

Checks performed:
- Target VM size is in the ARO-supported master sizes list
- SKU exists and is available in the cluster's Azure region
- SKU is not restricted in the customer's subscription
- Subscription has enough compute quota in the target VM family

The validation functions are structured as independent paths to
support future parallelization via errgroup.  TODO placeholders
are included for Service Principal and API server health checks.

* Refactor SKU validation into errgroup for parallel pre-flight checks

Extract SKU/quota validation into validateVMSKU method and wire it as
the first goroutine in an errgroup.WithContext, preparing the structure
for API server health and Service Principal checks in follow-up commits.

- Remove unused preResizeValidationResult struct and TODO stubs
- Move vmSize and master-size validation into validateVMSKU
- Fix test fixtures to include cluster/subscription docs for vmSize
  validation cases (DB lookup now precedes SKU checks)
- Document Azure capacity vs quota limitation on checkResizeComputeQuota

* Add API server health validation to pre-resize checks

Query the kube-apiserver ClusterOperator via kubeActionsFactory and
verify it is healthy (Available=True, Progressing=False, Degraded=False)
before allowing control plane VM resize. A degraded API server would
compound the risk of losing etcd quorum during the resize loop.

- Add validateAPIServerHealth using KubeGet + clusteroperators.IsOperatorAvailable
- Wire as second errgroup goroutine alongside SKU validation
- Create k... (continued)

215 of 248 new or added lines in 3 files covered. (86.69%)

26312 of 71697 relevant lines covered (36.7%)

0.42 hits per line