MyIntervals / emogrifier / 23052331720

96%

push

github

[CLEANUP] Streamline PCRE callbacks (#1598)

* [CLEANUP] Have specific methods for PCRE callbacks

PHPStan does not seem to understand the type annotations when they are
presented inline.  (Or possibly, the clumsy array representation of callbacks
obfuscates whatever is the issue, following this change.)

Anyhow, having them as separate methods improves the code design (IMO).

The callbacks need to be public so that the 'Safe' library can access them
(only the internal PHP functions are allowed to access private methods),
so are marked `@internal`.

Also expand on DocBlock comment regarding loose type to indicate the issue
primarily relates to using the 'Safe' library.

9 of 9 new or added lines in 1 file covered. (100.0%)

837 of 870 relevant lines covered (96.21%)

256.42 hits per line