kubevirt / hyperconverged-cluster-operator / 23049885880

79%

push

github

CNV-78906: Refactor the feature gate structure in API v1 (#4079)

* refine v1beta1 FG comments to match also v1

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* Add shared feature gate types package

Add pkg/featuregates with Phase type and FeatureGate struct

Introduce pkg/featuregates as the shared package for feature gate
metadata types, used by both the code generator tool and production
code. Defines Phase (GA, beta, alpha, deprecated) with JSON
marshaling, FeatureGate struct, and FeatureGates slice with Sort().

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* Add fg-json-generator tool

Add tool to generate feature gate JSON and conversion code from AST

Parses the v1beta1 HyperConvergedFeatureGates struct using go/ast to
extract feature gate metadata (JSON name, Go field name, phase,
description). Supports two modes: JSON output for feature gate catalog,
and --conversion mode for generating v1beta1<->v1 conversion functions.

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* Add feature gate details package with go:generate

Add pkg/featuregatedetails to serve feature gate phase lookups

Embeds the generated feature-gates.json and provides GetFeatureGatePhase()
for runtime phase lookups. Wired via go:generate to the fg-json-generator
tool.

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* Add v1 feature gates as a slice-based API

Refactor v1 feature gates from struct to slice of FeatureGate

Replace the v1 HyperConvergedFeatureGates struct (individual *bool
fields) with a slice-based []FeatureGate type in a new
api/v1/featuregates sub-package. Includes Enable/Disable/IsEnabled
methods, custom JSON marshaling, and deepcopy/openapi generation.

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* Add fg-v1-comments tool for v1 field documentation

Add tool to auto-generate the FeatureGates field comment in v1

Generates a structured comment listing all feature gates with their
descrip... (continued)

84 of 95 new or added lines in 4 files covered. (88.42%)

9614 of 12095 relevant lines covered (79.49%)

2.0 hits per line