NVIDIA / holodeck / 23049306583

49%

main: 48%

push

github

fix: wire Transport into SSH connection path and add cleanup

Address Distinguished Engineer review findings for PR #724:

B1 (BLOCKING): connectOrDie() now uses transport.Dial() + ssh.NewClientConn()
when a Transport is provided, instead of ignoring the transport and calling
ssh.Dial("tcp", ...) directly. All reconnection paths (waitForNodeReboot,
provision) pass p.transport through.

B2 (BLOCKING): installK8sPrereqs() and GetClusterHealth() now use
transportOptsForNode() to pass transport options to New().

R1: SSMTransport.Dial() is now idempotent — closes any existing session
before starting a new one.

R2: Transport interface includes Close() method. DirectTransport has a
no-op Close(). SSMTransport.Close() terminates the SSM process.

R3: SSM stderr is captured in a bytes.Buffer and included in error
messages for diagnostics.

R4: GetClusterHealth() builds transport options from node info in
environment status.

Signed-off-by: Eduardo Arango <earango@nvidia.com>
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

5 of 69 new or added lines in 3 files covered. (7.25%)

2959 of 6020 relevant lines covered (49.15%)

0.55 hits per line