23048368826
50%
main: 48%

Ran 13 Mar 2026 11:18AM UTC

Jobs 1

Files 37

Run time 1min

Badge

Embed ▾

Committed 13 Mar 2026 11:15AM UTC coverage: 49.567%. Remained the same

Build # 23048368826

Build Type

push

github

Committed by

ArangoGutierrez

Commit Message

fix: move NODE_PRIVATE_IP and NLB switch outside init guard

Address 4 issues from Distinguished Engineer review:

1. BLOCKING: NODE_PRIVATE_IP and INIT_ENDPOINT were scoped inside
   the `if [[ ! -f admin.conf ]]` block but used outside it for
   API verification and NLB switch — would crash on re-run.
   Moved both assignments before the init guard.

2. Escape dots in INIT_ENDPOINT for sed regex safety — IP addresses
   contain literal dots that are regex metacharacters.

3. Move NLB switch block to after Calico installation per design:
   NLB health checks require a working CNI to pass. Previous
   position was before Calico, violating the design contract.

4. Add test assertion verifying Calico installation happens before
   NLB endpoint switch.

Signed-off-by: Eduardo Arango <earango@nvidia.com>
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

Run Details

2916 of 5883 relevant lines covered (49.57%)

0.56 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	23048368826.1	13 Mar 2026 11:18AM UTC	37	49.57	GitHub Action Run

NVIDIA / holodeck / 23048368826
50%
main: 48%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 23048368826

NVIDIA / holodeck / 23048368826 50% main: 48%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 23048368826

NVIDIA / holodeck / 23048368826
50%
main: 48%

README BADGES
x