stacklok / toolhive / 23041861605

64%

Build Type

push

github

Committed by web-flow

Commit Message

Enable session management v2 by default (#4091)

* Enable session management v2 flag by default

* solve bugs and fix tests

Regenerate aggregator mock to restore alphabetical method order

MergeCapabilities was placed after ProcessPreQueriedCapabilities in the
mock file. Running go generate restores the mockgen-expected alphabetical
order to pass the codegen verification CI check.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Fix composite tool name collision in SMv2 session registration

The v2 session registration path (handleSessionRegistrationV2) was adding
composite tools without checking for name conflicts with backend tools,
unlike the v1 injectCapabilities path which uses validateNoToolConflicts.

- Add GetMultiSession to the SessionManager interface so server.go can
  access the session's resolved backend tool list for conflict validation
- Call validateNoToolConflicts before registering composite SDK tools,
  skipping them (with an error log) if a collision is detected
- Track actual composite tools added for accurate log output

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Fix composite tool routing failure in SMv2 path

Composite tool workflow steps call the shared router which reads
DiscoveredCapabilities from the request context, but the discovery
middleware was short-circuiting for MultiSession sessions and never
injecting them, causing "capabilities not found in context" errors.

- Add GetRoutingTable() to the MultiSession interface and implement it
  on defaultMultiSession (routing table is immutable post-creation)
- Update discovery middleware: instead of skipping context injection for
  MultiSession, build AggregatedCapabilities from the session's routing
  table and inject it — enabling composite tool workflow steps to route
  backend tool calls correctly
- Guard against nil routing table (session initialisation not yet complete)
- Add GetRoutingTable() stub to test fakes in session manager and
  integr... (continued)

Run Details

171 of 255 new or added lines in 12 files covered. (67.06%)

28 existing lines in 5 files now uncovered.

48670 of 75494 relevant lines covered (64.47%)

73.39 hits per line