redhat-developer / yaml-language-server / 23024249157

85%

master: 80%

push

github

Remove annoying log output related to modelines

Currently, a log entry is emitted whenever a modeline comment is parsed.
This is because, in
https://github.com/redhat-developer/yaml-language-server/pull/1193,
the logic for how modelines were parsed was changed.
On this line: https://github.com/redhat-developer/yaml-language-server/pull/1193/changes#diff-dc843f2ff82e0e9a3aa6fc6d996976bb2L21
there is always 2 entries if a parsable modeline is present.
This is because the index 0 entry contains the entire match,
and the index 1 entry contains the group match (that contains
the URI of the schema).
This means that the `console.log()` will always run,
incorrectly alerting the user that they tried to specify two schemas in
the modeline.

Even if the message were accurate, I don't think logging is the best way
to alert the user to this problem.
This should ideally be a warning or error instead.
For now, I'm removing the `console.log()` entirely to address this.

Signed-off-by: David Thompson <davthomp@redhat.com>

2981 of 3711 branches covered (80.33%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

4409 of 4957 relevant lines covered (88.94%)

253133.59 hits per line