Qiskit / qiskit / 23020635570
88%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 909
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 87.515% (-0.03%) from 87.544%
23020635570

push

github

web-flow 
Unify GitHub Actions branch-protection run logic (#15794)

Currently, whenever we need to bump the runner image or Python versions
used in the pull-request and merge-queue Actions workflows, we then have
to spend a lot of time updating the branch-protection rules in the
GitHub web interface (which is fiddly and error prone), and then update
every active PR to ensure it triggers the new rules and can move into
the merge queue.

Neither of these two things ought to be necessary:

* branch-protection rules _can_ be configured in code.  While this does
  technically relax the number of people who can modify the final
  branch-protection permissions (by nature of approving reviews to
  change the `branch-protection.yml` file), in practice nothing has
  actually changed, because it was always possible to simply stub out
  the required rules.

* if a PR is not _already_ in the merge queue while we are changing the
  branch-protection rules, but has already passed the (previous) set of
  protection rules, it will still have to pass the new rules on entry to
  the merge queue.

This commit centralises all the actual branch-protection rules into a
source-control-tracked in-code configuration.  The separate
`on-merge-queue.yml` and `on-pull-request.yml` files are unnecessary
because they were necessarily largely the same already in order for the
branch protection to function correctly, so were duplicating the same
configuration.  In addition, we provide a single in-code "job" that does
nothing but depend on all other branch-protection rules.  This lets us
specify only that job in the branch-protection rules in the GitHub web
interface, vastly simplifying the opaque web-only configuration, and
making it no longer vary based on the names of individual subjobs.

We also previously spread the configuration of runner-image and
Python-version selection into many places across many files, making it
rather hard to update when the Python versions changed.  Here, we
centr... (continued)

101203 of 115641 relevant lines covered (87.51%)

1166738.48 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
5
91.77
 -0.51% crates/qasm2/src/lex.rs
10
73.98
 -0.41% crates/circuit/src/parameter/symbol_expr.rs
24
96.21
 -1.9% crates/qasm2/src/parse.rs
Jobs
ID Job ID Ran Files Coverage
1 23020635570.1 909
87.51
 GitHub Action Run
Source Files on build 23020635570