stacklok / toolhive / 23020814602

64%

Build Type

push

github

Committed by web-flow

Commit Message

Remove discovery cache to fix flaky vMCP tests (#4110)

The discovery manager's per-user capability cache was causing flaky E2E test failures in virtualmcp_discovered_mode_test.go. When a new backend wasn't ready during the first AggregateCapabilities call, the partial result (e.g., 4 tools from 2 backends instead of 6 from 3) was cached and served for all subsequent requests for up to 5 minutes (TTL).
Since new MCP sessions are infrequent and aggregation latency is negligible compared to LLM round-trips, the cache is premature optimization. This PR removes it entirely, computing discovery results fresh on each request.
Reverts the QueriedBackendCount field added to AggregationMetadata in the initial fix approach, since it's no longer needed without caching.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Run Details

6 of 6 new or added lines in 1 file covered. (100.0%)

35 existing lines in 4 files now uncovered.

48472 of 75316 relevant lines covered (64.36%)

73.21 hits per line