pulibrary / orangelight / 6871fd37-b2dc-4464-87ca-429a060bc7a2

95%

push

circleci

Refactor pick up locations logic into small classes and a factory (#5675)

* Refactor pick up locations logic into small classes and a factory

Prior to this commit, pick up locations logic was in the Requestable
class and in the Application Helper.  Pulling it out to its own
classes increases cohesion, and gives smaller classes where it's
easier to modify behavior (such as #5238)

* Remove misleading tests, update mocks

* Simplify and clarify logic for annex and partner items

Co-authored-by: Christina Chortaria <christinach@users.noreply.github.com>

---------

Co-authored-by: Christina Chortaria <christinach@users.noreply.github.com>

131 of 133 new or added lines in 9 files covered. (98.5%)

6330 of 6655 relevant lines covered (95.12%)

1397.77 hits per line