Qiskit / qiskit / 23009044451
87%
main: 88%

LAST BUILD BRANCH: fix-15509-substitute-node-variables
DEFAULT BRANCH: main
Ran
Jobs 1
Files 909
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 87.497% (-0.3%) from 87.802%
23009044451

push

github

web-flow 
Rust QPY version 13 compatibility (#15663)

* Failing tests for version 16 and 14

* Added support for V16 PauliEvolutionPack

* Streamline QPYCircuit reading, and add support to version 14 annotations-less header

* Added support for string-based symbol table hashing for SUBS command in parameter expressions for QPY 14 (note: this cannot be tested in current qiskit where SUBS commands are no longer generated; we compare against qpy_compat data)

* Small fixes

* Small fixes. Differentiate supported rust read version and rust write version.

* Avoid using rust for pre 2.0.0 QPY files due to pusle calibrations handling

* Add support for reading calibration data

* Added context to error messages in qpy compatibility testing

* Added error context printing for qpy_compat tests, added support for CircuitData in GenericValue, added support for reading non control flow gates with conditionals in QPY (required for version 13 backwards compatibility), refactored backwards compatibility related code to a separate file

* Also add formats file

* Linting

* Bugfix in `instruction_values_to_params`

* Treat python control flow instructions as rust control flow instructions (other than SwitchCaseOp which has different parameter format and needs to be handled more carefully)

* Small fix: Now that we handle python ForLoopOp directly, we need to account to their parameters being given in little endian.

* Fixed according to PR review

* There's no need to hardcode the QPY version when we should take it from qpy_data

* Fixes according to PR review

* Move `backwards_comp` items to `formats` and `circuit_reader`; fixed the formats for schedule blocks

* Revert unrelated code ordering change in TryFrom<Bytes>

This commit reverts an unrelated code ordering change. This was masking
the functional change in the PR which was changing the trait definition
from being for an borrowed Bytes to an owned Bytes. This change on it's
own makes sense but it was hard to see what... (continued)

102 of 175 new or added lines in 9 files covered. (58.29%)

323 existing lines in 12 files now uncovered.

101173 of 115630 relevant lines covered (87.5%)

1165548.3 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
90.72
 0.0% crates/circuit/src/instruction.rs
2
83.29
 -0.79% crates/qpy/src/py_methods.rs
11
79.84
 -2.23% crates/qpy/src/value.rs
15
77.01
 -1.13% crates/qpy/src/params.rs
44
84.58
 -4.59% crates/qpy/src/circuit_reader.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
86.99
 0.0% crates/circuit/src/parameter/parameter_expression.rs
1
74.14
 0.08% crates/circuit/src/parameter/symbol_expr.rs
1
74.32
 -6.23% crates/qpy/src/formats.rs
2
83.29
 -0.79% crates/qpy/src/py_methods.rs
3
77.01
 -1.13% crates/qpy/src/params.rs
3
79.84
 -2.23% crates/qpy/src/value.rs
5
92.8
 0.0% crates/qasm2/src/lex.rs
6
97.15
 0.0% crates/qasm2/src/parse.rs
6
41.51
 -5.16% qiskit/qpy/common.py
18
84.58
 -4.59% crates/qpy/src/circuit_reader.rs
69
33.16
 -11.62% qiskit/qpy/binary_io/value.py
208
33.26
 -24.04% qiskit/qpy/binary_io/circuits.py
Jobs
ID Job ID Ran Files Coverage
1 23009044451.1 909
87.5
 GitHub Action Run
Source Files on build 23009044451