tari-project / tari / 23005727524

62%

Build Type

push

github

Committed by web-flow

Commit Message

chore: remove neighbour/distance peer pool distinction from DHT connectivity (#7702)

DHT connectivity maintained two separate peer pools — a `neighbours`
pool (originally distance-ordered) and a `random_pool` — which became
functionally identical after XOR-distance selection was removed. This PR
collapses them into a single unified pool.

## DHT Connectivity (`comms/dht/src/connectivity/mod.rs`)

- Removed `neighbours: Vec<NodeId>` field; all managed peers live in
`random_pool`
- Total pool capacity = `num_neighbouring_nodes + num_random_nodes`
(config fields preserved for backward compat)
- Removed functions: `refresh_neighbour_pool`,
`refresh_neighbour_pool_if_required`, `num_connected_neighbours`,
`insert_neighbour`, `redial_neighbours_as_required`,
`fetch_neighbouring_peers`
- `replace_pool_peer` now has a single branch (random pool only)
- `log_status` reports a single peer pool instead of separate
neighbour/random pools
- Ticker loop drops the `refresh_neighbour_pool_if_required` call;
single `refresh_random_pool_if_required` handles everything

## Config & Builder (`config.rs`, `builder.rs`)

- Updated doc comments on `num_neighbouring_nodes` / `num_random_nodes`
to drop "neighbour" framing — they now describe pool partitioning, not
topology
- `DhtConnectivityConfig` comment updated accordingly

## Tests (`connectivity/test.rs`)

- `insert_neighbour` → `insert_into_pool` (tests unified
`insert_random_peer` cap behaviour)
- `added_neighbours` → `added_pool_peers`
- `replace_peer_when_peer_goes_offline` rewritten to not rely on
specific peer indices (random selection makes index-based assertions
fragile)
- `initialize` checks dial count rather than specific peer IDs

<!-- START COPILOT ORIGINAL PROMPT -->



<details>

<summary>Original prompt</summary>

> 
> ----
> 
> *This section details on the original issue you should resolve*
> 
> <issue_title>Investigate removing all notions of distance to
peer</issue_title>
> <issue_description>I think w... (continued)

Run Details

98 of 115 new or added lines in 9 files covered. (85.22%)

72 existing lines in 18 files now uncovered.

70646 of 114431 relevant lines covered (61.74%)

227169.5 hits per line