stacklok / toolhive / 23006060128

64%

Build Type

push

github

Committed by web-flow

Commit Message

Add annotation cache for tools/list to tools/call flow (#4114)

* Add annotation cache for tools/list to tools/call flow

The authz middleware now caches tool annotations from tools/list
responses and injects them into context during tools/call requests.
This bridges the gap where annotations are visible in tools/list but
lost by the time tools/call arrives as a separate HTTP request.

- Add AnnotationCache with concurrent-safe get/set operations
- ResponseFilteringWriter populates cache during tools/list filtering
- Middleware closure captures cache, injects annotations for tools/call
- Graceful degradation when tools/call arrives before tools/list

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Fix stale annotation cache entries on tools/list

SetFromToolsList previously merged into the existing map, so tools
whose annotations were removed in a subsequent tools/list response
retained stale cached entries. Replace the entire map atomically
to ensure eviction of removed tools.

Also add a test for the eviction behavior and document the
intentional omission of the Title field in convertMCPAnnotation.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Run Details

62 of 65 new or added lines in 3 files covered. (95.38%)

39 existing lines in 4 files now uncovered.

48412 of 75349 relevant lines covered (64.25%)

73.47 hits per line