bitcoindevkit / bdk / 22990190924

80%

master: 78%

push

github

Merge bitcoindevkit/bdk#2150: `chain 0.23.x`: Fix assumed canonical tx always being unconfirmed

<a class=hub.com/bitcoindevkit/bdk/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk/commit/43850b5569cb22e004652b058ce5d13ca2ccd344">43850b556 fix(chain): Tx assumed to be canonical will not be forced unconfimred (志宇)

Pull request description:

  ### Description

  Fixes #2088
  Depends on #2148
  Backport of #2110

  ### Changelog notice

  ```md
  Fixed:
  - Previously, assumed-canonical transactions always became unconfirmed even though the transaction may be anchored in the best chain.
  ```

  ### Checklists

  #### All Submissions:

  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

  #### New Features:

  * [x] I've added tests for the new feature
  * [x] I've added docs for the new feature

  #### Bugfixes:

  * [x] I've added tests to reproduce the issue which are now passing
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  luisschwab:
    ACK 43850b5569cb22e004652b058ce5d13ca2ccd344
  notmandatory:
    ACK 43850b5569cb22e004652b058ce5d13ca2ccd344

Tree-SHA512: 72fa4211194258a4174dfae151efcc3ef8c

385 of 522 branches covered (73.75%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

4357 of 5430 relevant lines covered (80.24%)

2181.39 hits per line