stacklok / toolhive / 22979344797

64%

Build Type

push

github

Committed by web-flow

Commit Message

Re-panic http.ErrAbortHandler in recovery middleware (#4065)

Go's httputil.ReverseProxy intentionally panics with http.ErrAbortHandler
when a streaming response breaks mid-copy. Go's HTTP server has built-in
handling for this sentinel: catch it silently, close the connection, move on.

By intercepting ErrAbortHandler, the recovery middleware was:
- Logging noisy stack traces for something that isn't a bug
- Attempting to write http.Error() to an already-in-flight response
- Preventing Go's HTTP server from cleanly aborting the connection

This fix re-panics the sentinel, letting Go's HTTP server handle it as designed.

Fixes #4064

Signed-off-by: Greg Katz <gkatz@indeed.com>

Run Details

7 of 7 new or added lines in 1 file covered. (100.0%)

276 existing lines in 7 files now uncovered.

48245 of 75233 relevant lines covered (64.13%)

74.01 hits per line