stacklok / toolhive / 22965231106

64%

Build Type

push

github

Committed by web-flow

Commit Message

Add tool annotation context for Cedar/HTTP authz (#4102)

* Add tool annotation context for Cedar/HTTP authz

Cedar policies can reference entity attributes like
`resource.readOnlyHint == true`, but tool annotations were never
reaching the authorizers. This adds context-based annotation injection
so both Cedar and HTTP PDP authorizers can use MCP tool annotations
(readOnlyHint, destructiveHint, idempotentHint, openWorldHint) in
authorization decisions.

- Add ToolAnnotations struct and context helpers in authorizers package
- Cedar authorizer merges annotations into resource entity attributes
- HTTP PDP authorizer includes annotations in PORC context
- Foundation for annotation cache (PR 2) and vmcp flow (PR 3)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Harden tool annotation authz against attribute collisions

Reverse the Cedar mergeContexts order so standard resource attributes
(name, operation, feature) are applied last and cannot be overwritten by
annotation keys. Guard HTTP PDP annotation enrichment to tool-call
operations only. Add slog.Warn when enrichPORCWithAnnotations encounters
unexpected types instead of silently discarding context. Document the
trust boundary (annotations must come from the server-side registry) and
the asymmetric exposure paths between Cedar and HTTP authorizers.

Add unit tests for enrichPORCWithAnnotations (8 cases) and Cedar
attribute collision safety (5 cases).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Move AuthorizeWithJWTClaims back to original position in file

Restore the original method ordering so the PR diff only shows the
actual logic changes, not a spurious move.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Run Details

58 of 60 new or added lines in 3 files covered. (96.67%)

7 existing lines in 3 files now uncovered.

48069 of 74975 relevant lines covered (64.11%)

74.47 hits per line