tari-project / tari / 22961452314

62%

Build Type

push

github

Committed by web-flow

Commit Message

feat: show -p overrides in print-env and improve unknown-field config errors (#7701)

`print-env` only showed environment variables, omitting `-p` CLI
overrides. Additionally, when an env var or `-p` arg referenced an
unknown config field (e.g.
`TARI_BASE_NODE__P2P__TRANSPORT__TOR__PROXY_BYPASS_ADDRESSES_TEST`), the
app exited with an opaque serde error and no guidance.

## Changes

### `print-env` now includes `-p` args
- `print_env_vars()` signature changed to
`print_env_vars(config_overrides: &[(String, String)])` — both env vars
and `-p` overrides are displayed, with sensitive keys (PASSWORD, SECRET,
KEY, SEED) masked
- `--print-env` CLI flag in `minotari_node` and
`minotari_console_wallet` passes `cli.common.config_property_overrides`
to the function
- Interactive `print-env` shell command gains a
`config_property_overrides: Vec<(String, String)>` field on
`CommandContext`, populated from `cli.common.config_property_overrides`
in `run_base_node_with_cli`

### Better unknown-field error UX
- Added `ConfigurationError::is_unknown_field_error() -> bool` to avoid
`to_string()` allocation when detecting the error type
- `ApplicationConfig::load_from` failures in both node and wallet now
print an actionable hint:
  ```
⚠️ Configuration error: an environment variable or -p override
references an unrecognized config field.
Run with --print-env to inspect active environment variables and -p
overrides.
  ```

### Example output for `--print-env` / `print-env`
```
Tari-related environment variables:
  TARI_BASE_NODE__GRPC_ENABLED=true
  TARI_NETWORK=esmeralda

Config property overrides (-p args):
  base_node.grpc_enabled=true
  test.stuff=true
```

<!-- START COPILOT ORIGINAL PROMPT -->



<details>

<summary>Original prompt</summary>

> 
> ----
> 
> *This section details on the original issue you should resolve*
> 
> <issue_title>update envVars usage and help feedback</issue_title>
> <issue_description>shell envVars, like ```MINOTARI_NODE_ENABLE_GRPC```
as... (continued)

Run Details

55 of 103 new or added lines in 6 files covered. (53.4%)

13 existing lines in 7 files now uncovered.

71959 of 116069 relevant lines covered (62.0%)

225297.4 hits per line