mozilla-releng / balrog / #5298

90%

main: 90%

Pull #3707

circleci

Make AUS lazily open transactions to avoid unnecessary DB roundtrips

This defers the transaction creation until the first call to `execute`.

I was looking at why we had 60x more queries going to database than HTTP
queries. Because each request is wrapped in a `with_transaction`
decorator, at the moment they all open a transaction, do work which
might not hit the database (if the cache hit rate metrics is correct,
this should be ~95% of requests) and commit it at the end. That is a lot
of database roundtrips for no reason whatsoever.

2175 of 2556 branches covered (85.09%)

Branch coverage included in aggregate %.

13 of 14 new or added lines in 1 file covered. (92.86%)

5744 of 6251 relevant lines covered (91.89%)

0.92 hits per line