NVIDIA / holodeck / 22955709171

51%

Build Type

push

github

Committed by web-flow

Commit Message

fix: make kubeadm config local path unique per environment (#717)

* fix: make kubeadm config local path unique per environment

Parallel holodeck processes wrote kubeadm-config.yaml to the same
local path (~/.cache/holodeck/kubeadm-config.yaml), causing a race
condition where one process's config would overwrite another's before
SCP. This resulted in the wrong CRI socket being used by kubeadm.

Include the environment name in the filename so each process gets
its own file: kubeadm-config-<env-name>.yaml. Clean up the local
file after successful SCP to the remote host.

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

* fix: satisfy gosec G104 for os.Remove cleanup

Assign os.Remove return value to blank identifier instead of nolint
directive — gosec doesn't honor errcheck nolint comments.

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

---------

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

Run Details

4 of 9 new or added lines in 1 file covered. (44.44%)

1 existing line in 1 file now uncovered.

2895 of 5828 relevant lines covered (49.67%)

0.56 hits per line