mattwparas / steel / 22936788704

51%

Build Type

push

github

Committed by web-flow

Commit Message

make the port procedures respect `parameterize` (#644)

* allow defaulting the port for (read-port-to-<string/bytes>)

and adjust the docs for that

* make parameterizing work on read-char, read-byte, etc

trying to parameterize the read-char / read-byte / etc procedures
previously didn't work, as they were implemented in rust, where the
rust builtin would just fall back to stdin / stdout for default ports.

the easiest way to make parameterizing work is by making the rust
builtins hidden and basically writing wrapper procedures on the steel
side, where parameterizing already just works.

this also means, that the rust builtins can now just take two arguments
instead of trying to make it callable with only one, eliminating the
need for the `io_args` procedures.

before:

```
λ > (define port (open-output-string))
λ > (parameterize ([current-output-port port])
      (write-char #\a))
a
λ > (get-output-string port)
=> ""
```

after:

```
λ > (define port (open-output-string))
λ > (parameterize ([current-output-port port])
      (write-char #\a))
λ > (get-output-string port)
=> "a"
```

* copy port docs to scheme module

* cargo xtask docgen

* rename default-current-<direction>-port to just default-<direction>-port

those procedures were previously also used in the read-port etc
procedures, but since those have been moved to the steel side to fix
parameterizing, these are no longer needed as the rust-side private
builtins can just take a port unconditionally.

in my opinion calling them something with "current" is a little
misleading, as these are just constructors for the default error ports,
as they are not affected by parameterizing, which the
current-<direction>-port should be. additionally it the functions better
up with the private builtin wrapper procedures (their only call site),
as those are just called `#%default-<direction>-port`.

* add some tests for parameterizing

Run Details

18 of 18 new or added lines in 2 files covered. (100.0%)

81 existing lines in 7 files now uncovered.

19714 of 38841 relevant lines covered (50.76%)

3611280.18 hits per line