alexferl / zerohttp / 22928956751

94%

Build Type

push

github

Committed by web-flow

Commit Message

  fix: ignore subsequent WriteHeader calls in compress middleware (#75)

* fix: ignore subsequent WriteHeader calls in compress middleware

  WriteHeader was forwarding calls to the underlying ResponseWriter even
  when wroteHeader was true. This deviated from standard library behavior
  where subsequent WriteHeader calls are silently ignored.

  Changes:
  - Change WriteHeader to return early when wroteHeader is true
  - Add test to verify standard library behavior (subsequent calls ignored)

Signed-off-by: alexferl <me@alexferl.com>

* fix race condition on cleanup

Signed-off-by: alexferl <me@alexferl.com>

* remove notes

Signed-off-by: alexferl <me@alexferl.com>

---------

Signed-off-by: alexferl <me@alexferl.com>

Coverage Stats

3 of 5 new or added lines in 2 files covered. (60.0%)

2 existing lines in 1 file now uncovered.

8147 of 8703 relevant lines covered (93.61%)

47.35 hits per line