alexferl / zerohttp / 22927936641

94%

Build Type

push

github

Committed by web-flow

Commit Message

fix: release store lock before acquiring entry lock in rate limit store (#72)

The checkTokenBucket(), checkFixedWindow(), and checkSlidingWindow()
functions held the store lock while acquiring the entry lock. While
safe currently, this inconsistent lock ordering could lead to deadlocks
if the pattern changes in the future.

Changes:
- Release store lock (s.mu) before acquiring entry lock (entry.mutex)
- Update all three rate limit algorithms: token bucket, fixed window,
  sliding window
- Add comments explaining the lock ordering

Signed-off-by: alexferl <me@alexferl.com>

Coverage Stats

15 of 15 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

8128 of 8692 relevant lines covered (93.51%)

46.5 hits per line