codebar / planner / 22923752488

96%

master: 96%

Pull #2519

github

Update the default method when rendering a 404

This was a very strange bug. We found that users visiting `events/introduction-to-git-1/invitation/hello@codebar.io` (we don't know how this url was generated) caused the application to crash. We fixed it with 6c83d9287, but it bothered me that the 404 page was not our standard one.

It turns out that rails interprets a dot as a format separator. That meant the url was being parsed as `events/introduction-to-git-1/invitation/hello@codebar.`, with a format of 'io'. In our previous application_controller.rb file, that was caught by the line `     format.all  { head :not_found }`.

The result of this should be a nice splash page whenever there's a 404, including where a URL is malformed.

Signed-off-by: jonathan.kerr <3410350+jonodrew@users.noreply.github.com>

2 of 2 new or added lines in 2 files covered. (100.0%)

3331 of 3482 relevant lines covered (95.66%)

46.43 hits per line