rm-hull / fuel-prices-api / 22917808254

46%

Build Type

push

github

Committed by web-flow

Commit Message

feat: add data validation and dropping for fuel prices (#30)

* feat: add data validation and dropping for fuel prices

- Added `IsPriceOutOfBounds` check to filter out invalid price data
  before insertion.
- Updated `Repository` and `Client` interfaces to track and return the
  count of dropped records.
- Added `fuel_prices_govuk_api_items_dropped_total` metric to monitor
  data quality issues.
- Renamed binary to `fuel-prices-api` in `Dockerfile` and build scripts.

```mermaid
sequenceDiagram
    participant API as GovUK API
    participant Client as Fetcher
    participant Repo as Repository

    Client->>API: Fetch batch
    API-->>Client: Return records
    loop Each Record
        Client->>Repo: InsertPFS / InsertPrices
        alt Out of Bounds
            Repo-->>Client: Drop record
        else Valid
            Repo-->>Repo: Save to SQLite
        end
    end
    Client->>Client: Increment dropped count
    Client->>Client: Record metrics (Fetched/Dropped)
```

* fix: update metrics for dropped items

Ensure that `ItemsDroppedTotal` metrics are recorded even when
`count` is zero, and improve nil safety checks.

Run Details

15 of 68 new or added lines in 6 files covered. (22.06%)

1 existing line in 1 file now uncovered.

211 of 1199 relevant lines covered (17.6%)

0.19 hits per line