22908162088
93%

Ran 10 Mar 2026 02:45PM UTC

Jobs 1

Files 257

Run time 1min

Badge

Embed ▾

Committed 10 Mar 2026 02:42PM UTC coverage: 92.85% (+0.006%) from 92.844%

Build # 22908162088

Build Type

push

github

Committed by

web-flow

Commit Message

Fix str incorrectly validating as list[str] in ConditionalRouter (#10766)

* Fix str incorrectly validating as list[str] in ConditionalRouter

Two issues fixed in _output_matches_type():

1. A plain str value incorrectly passes validation for list[str]
   because str is a Sequence in Python. Added an explicit check to
   exclude str and bytes before the Sequence isinstance check.

2. Removed duplicate dead code block (second `if origin is None`
   check) that was unreachable after the Sequence handling.

Signed-off-by: JiangNan <1394485448@qq.com>

* Add test for str not matching list[str] in ConditionalRouter

Verifies that a plain str value is correctly rejected when the expected
output type is list[str], preventing false validation passes.

Signed-off-by: JiangNan <1394485448@qq.com>

* Add release note for str/list[str] validation fix

Signed-off-by: JiangNan <1394485448@qq.com>

* adding release notes

* formatting

* fixing release notes

* fixing release notes inline code

* fixing release notes inline code

* fixing release notes inline code

* removing duplicated release notes and fixing already existing ones

---------

Signed-off-by: JiangNan <1394485448@qq.com>
Co-authored-by: David S. Batista <dsbatista@gmail.com>

Run Details

15636 of 16840 relevant lines covered (92.85%)

0.93 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
3	95.09	0.61%	components/routers/conditional_router.py

Jobs

ID	Job ID	Ran	Files	Coverage
1	22908162088.1	10 Mar 2026 02:45PM UTC	257	92.85	GitHub Action Run

deepset-ai / haystack / 22908162088
93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 22908162088

deepset-ai / haystack / 22908162088 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 22908162088

deepset-ai / haystack / 22908162088
93%

README BADGES
x