supabase / supavisor / 22906196335

82%

Build Type

push

github

Committed by web-flow

Commit Message

feat: improve errors, add error codes (#841)

This changes a lot of errors from being atoms handled ad-hoc to be
structured errors. Structured errors allow us to have more
error-associated behavior, for example, every error can have a code, and
associated information to be used in logs. These structured errors also
allow us to have shared code paths in the caller code, reducing the
complexity of error handling in core parts of the codebase (e.g.: the
connection state machines).

This PR introduces an error behaviour (which is used alongside the
Exception behaviour) which has callbacks for log message and protocol
message (to be sent on the wire if this error happens for a client
connection), and an Error use-macro which makes the behaviour
implementation simple and does basic validation (does this error have a
code?).

It also introduces a new assertion, which we can use on returned errors,
to ensure that they are loggable and won't crash with the behaviour 
implementation. I haven't implemented it everywhere yet, but I think
it's a good addition for coverage.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Standardized, structured error types with machine-readable codes and a
new API to expose the max startup packet size.

* **Bug Fixes**
* More explicit, consistent error responses for auth, SSL/handshake,
subscription, pool/worker not-found, checkout timeouts and client-limit
conditions.
* Improved PostgreSQL protocol error formatting and unified
error-handling pathways.

* **Tests**
* Expanded test coverage to assert new error shapes and startup/checkout
edge cases; added validation helpers for error formatting.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Run Details

181 of 224 new or added lines in 45 files covered. (80.8%)

5 existing lines in 4 files now uncovered.

2369 of 2978 relevant lines covered (79.55%)

57920.32 hits per line