tarantool / luajit / 22898134895

93%

tarantool/master: 93%

Build Type

push

github

Committed by Buristan

Commit Message

DUALNUM: Add missing type conversion for FORI slots.

Reported by Sergey Kaplun.

(cherry picked from commit 406cf69b3)

`rec_for_loop()` narrows the FORL index values by getting them from the
runtime. In case when the `start`, `stop`, `step` control variables are
already loaded to the slots, their TRef isn't converted to the
corresponding type. This leads to the following inconsistent IR dump and
to the assertion failure later:
| 0002 > int SLOAD  10   TCI
| 0003   int ADD    0002  +1.
| 0004 > int LE     0003  +1.
| 0005   int ADD    0003  +1.
| 0006 > int GT     0005  +1.

This patch adds the missing type conversion.

Sergey Kaplun:
* added the description and the test for the problem

Part of tarantool/tarantool#12134

Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org>
Signed-off-by: Sergey Kaplun <skaplun@tarantool.org>
(cherry picked from commit ca29e5f72)

Run Details

5709 of 6046 branches covered (94.43%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 1 file covered. (100.0%)

7 existing lines in 2 files now uncovered.

21796 of 23516 relevant lines covered (92.69%)

3946502.37 hits per line