SAP / ui5-project / 22896985868

96%

main: 96%

push

github

[INTERNAL] Bump ajv from 6.14.0 to 8.18.0 and ajv-errors from 1.0.1 to 3.0.0 (#860)

JIRA: CPOUI5FOUNDATION-859

PoC resolution in v4: https://github.com/SAP/ui5-project/pull/427

v5 implementation: https://github.com/UI5/cli/pull/1309

### Performance
There's a slight performance degradation after the update. This is an
expected behaviour as the code behind the generated validation function
has evolved. They have added more comprehensive checks in there and more
verbose logging. This is clearly visible in the coverage reports that we
have integrated for tha function in our test scenarios.

#### Comparisson

Command: `time ui5 build`

##### sap.m

###### After
info ProjectBuilder Build succeeded in 18 s  
info ProjectBuilder Executing cleanup tasks...  
ui5 build  36.37s user 11.09s system 246% cpu 19.237 total

###### Before
info ProjectBuilder Build succeeded in 17 s  
info ProjectBuilder Executing cleanup tasks...  
ui5 build  35.54s user 10.14s system 247% cpu 18.480 total

---

##### sap.ui.core

###### After
info ProjectBuilder Build succeeded in 9.42 s  
info ProjectBuilder Executing cleanup tasks...  
ui5 build  23.09s user 5.16s system 276% cpu 10.212 total

###### Before
info ProjectBuilder Build succeeded in 9.43 s  
info ProjectBuilder Executing cleanup tasks...  
ui5 build  22.54s user 5.43s system 273% cpu 10.242 total

1457 of 1560 branches covered (93.4%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

2836 of 2925 relevant lines covered (96.96%)

129.62 hits per line